Skip to content

Products Onboarding: Remove unused web auth code #8138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2022
Merged

Products Onboarding: Remove unused web auth code #8138

merged 2 commits into from
Nov 17, 2022

Conversation

@ealeksandrov
Copy link
Contributor

@ealeksandrov ealeksandrov commented Nov 16, 2022

Closes: #8097

Description

This PR removes unused RequestAuthenticator and its dependencies from WebKitViewController.

Testing

  1. Go to the Products tab and open existing product draft.
  2. Tap the Preview button in the navbar.
  3. Confirm that you can see a webview with product preview on your store.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ealeksandrov ealeksandrov added the feature: product details Related to adding or editing products, including Product Settings. label Nov 16, 2022
@ealeksandrov ealeksandrov added this to the 11.3 milestone Nov 16, 2022
@peril-woocommerce
Copy link

peril-woocommerce bot commented Nov 16, 2022 •
edited
Loading

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 16, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8138-7982d85 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Ecarrion
Ecarrion approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@Ecarrion Ecarrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this!

@ealeksandrov ealeksandrov merged commit ce065c0 into trunk Nov 17, 2022
@ealeksandrov ealeksandrov deleted the issue/8097-remove-unused-auth-code branch November 17, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rachelmcr rachelmcr Awaiting requested review from rachelmcr

1 more reviewer

@Ecarrion Ecarrion Ecarrion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature: product details Related to adding or editing products, including Product Settings.

Projects

None yet

Milestone

11.3

Development

Successfully merging this pull request may close these issues.

Products Onboarding: Remove Unnecessary code

4 participants

@ealeksandrov @wpmobilebot @Ecarrion