Remove not needed functions.

[toupper]

Closes: #8119

Description

We remove here some wrapper functions around Apple's withTintColor because we didn't have any added value with them.

Testing instructions

Please check that the primary, secondary, and tertiary buttons still have the intended background and border colors. For instance, the 'Next' button in IssueRefundViewController displays correctly:

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-woocommerce]

	Warnings
⚠️	This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

[wpmobilebot]

You can test the changes from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr8139-c5b0e84 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[iamgabrielma]

LGTM. I left 2 questions in the comments 👍

[iamgabrielma]

💯

While checking why would we be force-unwrapping this, I saw there's several instances of imageWithTintColor(tintColor)! as well, which has been renamed to withTintColor(_:) and the force-unwrapping can be removed too. Would make sense to fix these as well as part of this PR? Or I can open a new issue otherwise.

[toupper]

Thanks for the hint here @iamgabrielma
We have some references to the WordPressUI function imageWithTintColor, which returns an optional, hence the force unwrapping. I didn't change those, because I didn't know if by doing so we would get any unexpected change (imageWithTintColor has its own implementation that might differ from Apple's). Because of that, I think creating a new issue to check on those is the right course of action here.

[iamgabrielma]

Gotcha! I opened a new one here: #8151

[iamgabrielma]

It would seem we've inadvertently moved this file in the project structure? I can't see any other changes 🤔

[toupper]

That was automatically done by Xcode when deleting UIImage+TintColor.swift , but please note that the order of the files in that pbxproj field doesn't match the order in the project structure, so I wouldn't worry about it.