Skip to content

Store creation M2: domain selector updates #8165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 24, 2022
Merged

Store creation M2: domain selector updates #8165

merged 14 commits into from
Nov 24, 2022

Conversation

@jaclync
Copy link
Contributor

@jaclync jaclync commented Nov 21, 2022

Parts of #8045

Description

This PR updated the domain selector screen based on the design feedback and updates in the past two weeks:

  • Update placeholder image - dark mode, transparent background
  • Auto-focus the text field --> I ended up not doing this because the search is pre-filled with the store name in the previous screen
  • Update no search results error
  • Update spacing between elements
  • Update search field trailing padding, and decrease space around the search icon (ref)
  • Update bottom Continue CTA to use safeAreaInset
  • Update SUGGESTIONS header text to footnote font
  • Remove the skip button pecCkj-dp-p2
  • Auto-dismiss the keyboard after selecting a domain and the continue button appears (ref)

Testing instructions

Please ignore the back button text in the navigation bar, this is updated in a separate PR #8154.

  • Log in if needed
  • Go to the Menu tab, and tap Switch store
  • On the store picker, tap + Add a store
  • Tap Create a new store --> the domain selector should be shown with a placeholder image
  • Enter some store name and tap Continue --> the store name should be the initial query in the next domain search screen, and some domain results are loaded
  • Remove the search query --> the empty state should match design and looks good in dark mode
  • Enter some other search query --> the spinner should appear, and some search results are loaded shortly
  • Tap to select a domain --> a Continue CTA should appear at the bottom, and the keyboard should be resigned
  • Enter some very long query --> there should be some space in the search field trailing edge
  • Replace the search query to be Test to have no results --> an error message should be shown, center-aligned

Screenshots

empty query suggestions domain selected loading error
Simulator Screen Shot - iPhone 14 - 2022-11-21 at 14 25 44 Simulator Screen Shot - iPhone 14 - 2022-11-21 at 14 26 00 Simulator Screen Shot - iPhone 14 - 2022-11-21 at 14 26 04 Simulator Screen Shot - iPhone 14 - 2022-11-21 at 14 26 20 Simulator Screen Shot - iPhone 14 - 2022-11-21 at 14 26 15
Simulator Screen Shot - iPhone 14 - 2022-11-21 at 14 26 30 Simulator Screen Shot - iPhone 14 - 2022-11-21 at 14 26 38 Simulator Screen Shot - iPhone 14 - 2022-11-21 at 14 26 40 Simulator Screen Shot - iPhone 14 - 2022-11-21 at 14 26 48 Simulator Screen Shot - iPhone 14 - 2022-11-21 at 14 27 19
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jaclync jaclync added type: enhancement A request for an enhancement. status: feature-flagged Behind a feature flag. Milestone is not strongly held. labels Nov 21, 2022
@jaclync jaclync added this to the 11.4 milestone Nov 21, 2022
@jaclync
Merge branch 'feat/8108-iap-integration' into feat/8045-domain-select…
91890a5 
…or-updates

* feat/8108-iap-integration:
  MockInAppPurchases: update comments.
  Only use `MockInAppPurchases` in DEBUG builds.
  Add test cases for `StoreCreationCoordinator` with different IAP eligibility states.
  Update comments to improve readability, remove some TODOs.
  Store creation flow: move navigation title and large title style from hosting controller to SwiftUI view to fix large title issues.
  StoreCreationCoordinator: minor renaming on the store plan variable.
  Use `WooNavigationController` to disable "Back" text in the navigation bar back button.
  Present the in-progress view while waiting for IAP eligibility check instead of pushing it to the navigation stack (with an odd background glitch).
  Replace debug macro with a feature flag `storeCreationM2WithInAppPurchasesEnabled`.
  Show success screen after the created site becomes a Jetpack site.
  Create a mock for `InAppPurchasesForWPComPlansProtocol` to unblock store creation flow development.
  Only continue from plan purchase step if the result is successful.
  Show a temporary in-progress view while fetching IAP eligibility.
  Show the correct title in in-progress view while waiting for the site to be ready.
  Update the purchase action to be async and show a spinner in the purchase button.
  Purchase plan success --> in-progress view while waiting for the site to become a Jetpack site --> continue with the new Atomic site.
  StoreCreationPlanView: hide back button since there is already a close button.

# Conflicts:
#	WooCommerce/Classes/Authentication/Store Creation/StoreCreationCoordinator.swift
#	WooCommerce/Classes/ViewRelated/Dashboard/Settings/Domains/DomainSelectorView.swift
@jaclync jaclync changed the base branch from trunk to feat/8108-iap-integration November 21, 2022 06:42
@jaclync jaclync mentioned this pull request Nov 21, 2022
Closed
18 tasks
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 21, 2022 •
edited
Loading

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8165-1b685f4 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@selanthiraiyan selanthiraiyan self-assigned this Nov 22, 2022
selanthiraiyan
selanthiraiyan approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as described. 🎉

🚢

@jaclync
Update domain search placeholder.
a04aab2
@jaclync
Merge branch 'feat/8108-iap-integration' into feat/8045-domain-select…
2d31f8a 
…or-updates

* feat/8108-iap-integration:
  Update sample stats with averageOrderValue from mock
  Update metadata strings
  Update release notes for 11.3
  Add averageOrderValue to OrderStatsV4Totals storage entity
  Use Decimal type for consistent stats data handling
  Add Average Order Value to OrderStatsV4Totals model
@jaclync
Update domain selector view conditional logic with a state enum in th…
1b685f4 
…e view model.
@peril-woocommerce
Copy link

peril-woocommerce bot commented Nov 22, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

Base automatically changed from feat/8108-iap-integration to trunk November 24, 2022 00:38
@jaclync jaclync merged commit 9ab67ff into trunk Nov 24, 2022
@jaclync jaclync deleted the feat/8045-domain-selector-updates branch November 24, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeichigo itsmeichigo Awaiting requested review from itsmeichigo

1 more reviewer

@selanthiraiyan selanthiraiyan selanthiraiyan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@selanthiraiyan selanthiraiyan

Labels

status: feature-flagged Behind a feature flag. Milestone is not strongly held. type: enhancement A request for an enhancement.

Projects

None yet

Milestone

11.4

Development

Successfully merging this pull request may close these issues.

4 participants

@jaclync @wpmobilebot @selanthiraiyan