Skip to content

Conversation

@joshheald
Copy link
Contributor

Part of: #8080

Description

This makes no functional changes, and the code added is not yet called.

I've duplicated the CollectOrderPaymentUseCase ready for the planned refactor which will make Tap on Mobile easier. See pdfdoF-1My-p2 for full context.

The existing use case has been renamed LegacyCollectOrderPaymentUseCase, and when the refactor is complete and we switch over to it, this will be deleted.

CollectOrderPaymentUseCase is now the go-forward class, and I'll perform the refactor there and in other related files.

Testing instructions

Check that unit tests pass, and that you can still take a Card Present payment.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@joshheald joshheald added type: task An internally driven task. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. status: feature-flagged Behind a feature flag. Milestone is not strongly held. labels Nov 22, 2022
@joshheald joshheald added this to the 11.4 milestone Nov 22, 2022
@peril-woocommerce
Copy link

peril-woocommerce bot commented Nov 22, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8184-78e418f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@joshheald joshheald requested a review from toupper November 23, 2022 10:06
@joshheald
Copy link
Contributor Author

@toupper Sorry it's long. This is groundwork only: it duplicates the use case ready to start refactoring it, and the duplicate isn't even accessible. So it should be quick to test, and it's not worth reviewing the additional use case as it isn't any different from the existing one yet.

The plan is that this should make it a bit easier to pick out the changes in the refactor.

@joshheald joshheald marked this pull request as ready for review November 23, 2022 10:07
@toupper
Copy link
Contributor

toupper commented Nov 23, 2022

It looks good and tests well 🎉 :shipit:

Base automatically changed from issue/8172-add-localMobile-discovery-to-StripeCardReaderService to trunk November 24, 2022 15:13
@joshheald joshheald merged commit aea78e4 into trunk Nov 24, 2022
@joshheald joshheald deleted the task/partial-refactor-collect-order-payment-use-case branch November 24, 2022 15:13
@joshheald joshheald restored the task/partial-refactor-collect-order-payment-use-case branch November 24, 2022 16:36
@joshheald joshheald deleted the task/partial-refactor-collect-order-payment-use-case branch November 25, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: mobile payments Related to mobile payments / card present payments / Woo Payments. status: feature-flagged Behind a feature flag. Milestone is not strongly held. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants