Skip to content

Analytics Hub: Adjust UI for landscape orientation #8197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2022
+9 −2
Merged

Analytics Hub: Adjust UI for landscape orientation #8197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions WooCommerce/Classes/ViewRelated/Dashboard/Analytics Hub/AnalyticsHubView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ final class AnalyticsHubHostingViewController: UIHostingController<AnalyticsHubV
///
struct AnalyticsHubView: View {

/// Environment safe areas
@Environment(\.safeAreaInsets) var safeAreaInsets: EdgeInsets

@StateObject var viewModel: AnalyticsHubViewModel

var body: some View {
Expand All @@ -29,6 +32,7 @@ struct AnalyticsHubView: View {
Divider()
Text("Placeholder for Time Range Selection")
.padding(.leading)
.padding(.horizontal, insets: safeAreaInsets)
.frame(maxWidth: .infinity, minHeight: 84, alignment: .leading)
.background(Color(uiColor: .listForeground))

Expand All @@ -40,7 +44,8 @@ struct AnalyticsHubView: View {
Divider()

AnalyticsReportCard(viewModel: viewModel.revenueCard)
.background(Color(uiColor: .listForeground))
.padding(.horizontal, insets: safeAreaInsets)
.background(Color(uiColor: .listForeground))

Divider()
}
Expand All @@ -49,7 +54,8 @@ struct AnalyticsHubView: View {
Divider()

AnalyticsReportCard(viewModel: viewModel.ordersCard)
.background(Color(uiColor: .listForeground))
.padding(.horizontal, insets: safeAreaInsets)
.background(Color(uiColor: .listForeground))

Divider()
}
Expand All @@ -60,6 +66,7 @@ struct AnalyticsHubView: View {
.navigationTitle(Localization.title)
.navigationBarTitleDisplayMode(.inline)
.background(Color(uiColor: .listBackground))
.edgesIgnoringSafeArea(.horizontal)
}
}

Expand Down