Skip to content

Store creation M2: checkout flow - Yosemite layer changes #8205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 28, 2022
Merged

Store creation M2: checkout flow - Yosemite layer changes #8205

merged 4 commits into from
Nov 28, 2022

Conversation

@jaclync
Copy link
Contributor

@jaclync jaclync commented Nov 24, 2022

Part of #8108

⚠️ Please only review this PR if the base PR #8203 is approved without significant suggestions ⚠️

Description

We decided to go with a different checkout flow from what we originally planned in p1669122130164769/1668764715.771189-slack-C045CUK1Y3U (with demo in p1669190357377079/1668764715.771189-slack-C045CUK1Y3U). After the Networking layer changes #8203, this PR contains just the Yosemite layer changes for two PaymentActions: loading a WPCOM plan loadPlan, and creating a cart with a WPCOM plan for a site createCart. MockPaymentRemote was created for mocking the remote for easier unit testing on PaymentStore.

The app layer changes will be in the following PR.

Testing instructions

The actions aren't used in the app yet, just CI is sufficient.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jaclync
Revert "Remove Yosemite layer changes to reduce PR size."
f23c6a5 
This reverts commit fde4554.
@jaclync
Pass the original error when creating a cart.
81488d4
@jaclync
Merge branch 'feat/8108-web-checkout-networking' into feat/8108-web-c…
cafd3d3 
…heckout-yosemite

* feat/8108-web-checkout-networking:
  Rename `CreateCartError.noMatchingProduct` to `CreateCartError.productNotInCart` to match the scenario more.
@jaclync
Relay Networking.CreateCartError to Yosemite.CreateCartError.
3edd299
@jaclync jaclync added the type: task An internally driven task. label Nov 24, 2022
@jaclync jaclync added this to the 11.5 milestone Nov 24, 2022
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 25, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8205-3edd299 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Base automatically changed from feat/8108-web-checkout-networking to trunk November 25, 2022 02:00
This was referenced Nov 25, 2022
Merged
Closed
@itsmeichigo itsmeichigo self-assigned this Nov 28, 2022
itsmeichigo
itsmeichigo approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jaclync jaclync merged commit 118a3b8 into trunk Nov 28, 2022
@jaclync jaclync deleted the feat/8108-web-checkout-yosemite branch November 28, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

@selanthiraiyan selanthiraiyan Awaiting requested review from selanthiraiyan

Assignees

@itsmeichigo itsmeichigo

Labels

type: task An internally driven task.

Projects

None yet

Milestone

11.5

Development

Successfully merging this pull request may close these issues.

4 participants

@jaclync @wpmobilebot @itsmeichigo