Analytics Hub: Products Card UI #8215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ecarrion
added
the
category: tracks
Generated by 🚫 dangerJS |
Ecarrion
force-pushed
the
issue/8198-products-card-ui
branch
from
175f77b to
26d8897
Compare
Collaborator
You can test the changes from this Pull Request by:
|
rachelmcr
approved these changes
Nov 25, 2022
Contributor
rachelmcr
left a comment
rachelmcr
left a comment
There was a problem hiding this comment.
I have a small concern about the inconsistent card styles, but since this matches the design I don't think it's a blocker. 
| .footnoteStyle() | ||
|
|
||
| Text(Localization.itemsSold) | ||
| .headlineStyle() |
Contributor
There was a problem hiding this comment.
I see this matches the Figma designs, but I think it makes more sense to use .calloutStyle() here to match the other cards. Otherwise this card has a strangely different style. What do you think?
Contributor
Author
There was a problem hiding this comment.
I Initially tried it with calloutStyle() and it also looked off. I think once we have the product list will look better!
Ecarrion
force-pushed
the
issue/8198-products-card-ui
branch
from
26d8897 to
f052ed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #8198
Why
This PR adds the UI for the first half of the product card. The next half, the product list, will be added in #8199 .
This PR links the UI using some fake data on the main hub view model.
How
DeltaTagto its own type so it can be reused.AnalyticsProductCardwhich contains the product card UI.AnalyticsProductCardViewModelto allow for easier data transportation.Screenshot
# Test Steps
RELEASE-NOTES.txtif necessary.