Skip to content

[Analytics Hub] Use device timezone and calendar for stats requests #8316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2022
Merged

[Analytics Hub] Use device timezone and calendar for stats requests #8316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...asses/ViewRelated/Dashboard/Analytics Hub/Time Range/AnalyticsHubTimeRangeSelection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,10 @@ public class AnalyticsHubTimeRangeSelection {
return previousTimeRangeDescription
}

//TODO: abandon usage of the ISO 8601 Calendar and build one based on the Site calendar configuration
init(selectionType: SelectionType,
currentDate: Date = Date(),
timezone: TimeZone = TimeZone.autoupdatingCurrent,
calendar: Calendar = Calendar(identifier: .iso8601)) {
timezone: TimeZone = TimeZone.current,
calendar: Calendar = Locale.current.calendar) {
var selectionData: AnalyticsHubTimeRangeData

switch selectionType {
Expand Down