[Analytics Hub] Extract DeltaPercentage entity #8320
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8243
⚠️ Depends on #8317 ⚠️
Description
This extracts
DeltaPercentagefrom theStatsDataTextFormatter, for use as a separate entity.The original idea behind
DeltaPercentagewas to just be a representation of the formatted string/direction inStatsDataTextFormatter. Given that so many report card values depend on theDeltaPercentage, it seems relevant as a separate entity. This will help simplify the view model setup for each analytics card in the Analytics Hub.Changes
DeltaPercentagefrom theStatsDataTextFormatter. For the sake of formatting the delta percentage string, we still useStatsDataTextFormatterto generate the delta from the order stats data.DeltaPercentage. The convenience inits for each analytics card now maps the delta in the view model to the respective properties on the card.Testing
There should be no change in behavior:
Submitter Checklist
Update release notes:
RELEASE-NOTES.txtif necessary.