[Mobile Payments] Duplicate PaymentCaptureOrchestrator for refactor #8328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshheald
added
type: task
joshheald
changed the title
joshheald
changed the base branch from
trunk
to
issue/8295-tap-on-mobile-errors
Collaborator
You can test the changes from this Pull Request by:
|
1 task
toupper
reviewed
Dec 7, 2022
| /// 3. Obtain a Payment Intent from the card reader (i.e., create a payment intent, collect a payment method, and process the payment) | ||
| /// 4. Submit the Payment Intent to WCPay to capture a payment | ||
| /// Steps 1 and 2 will be implemented as part of https://github.com/woocommerce/woocommerce-ios/issues/4062 | ||
| final class LegacyPaymentCaptureOrchestrator { |
Contributor
There was a problem hiding this comment.
I like your approach when dealing with legacy code here, smaller PRs and meaningful renaming 👏
Contributor
|
The code looks good and it tests well 🎉 |
toupper
approved these changes
Dec 7, 2022
Generated by 🚫 dangerJS |
joshheald
deleted the
issue/8321-duplicate-payment-capture-orchestrator-for-refactor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #8321
Description
As per the proposal in pdfdoF-1My-p2, this PR duplicates the PaymentCaptureOrchestrator for use in the refactored and updated payment flows, as we add support for the built-in card reader in project sTAP Away.
There are no functional changes to either flow in this PR, it is purely preparatory for #8329
Testing instructions
Run unit tests
Check you can take a payment with the feature toggle in experimental features off and on.
RELEASE-NOTES.txtif necessary.