Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

Reported on #8312 (comment)

Description

This PR removes the auxiliaryButtonimage property from CardPresentModalScanningForReader which outputs a (¡) image along the button's text on different modal views through the CardPresent flow.

Context

With the usage of the new UIButton configuration API we have found some conflicts in the way we're dealing with button content configuration through this flow, in this case we have opted for removing the image temporarily as was the source of different design glitches.

We have opened a related issue to keep track of it, and restore the image in the future, when we migrate the modals to SwiftUI and apply the new button configuration API.

Before After
Before After

Changes

  • Remove auxiliaryButtonimage property
  • Add usage of UIButton.Configuration when styling the button

Testing instructions

  • Go to Menu > Manage Card Reader > Disconnect the reader if is connected > Tap on Connect Card Reader
  • See Learn More about In-Person Payments button. This is more easily checked by commenting out discoveredReadersSubject.send(wooReaders) here, so the flow doesn't move forward to the next step.
  • See Cancel button when the app prompts to connect a reader.

I'd left out of this PR further improvements like moving button title and attributedTitle to the button configuration because this needs more extensive testing. These are left to be done along this issue.

@iamgabrielma iamgabrielma added feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: enhancement A request for an enhancement. labels Dec 7, 2022
@iamgabrielma iamgabrielma added this to the 11.6 milestone Dec 7, 2022
@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8333-79c7f66 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@iamgabrielma iamgabrielma merged commit 46bc22a into trunk Dec 8, 2022
@iamgabrielma iamgabrielma deleted the task/remove-auxiliarybutton-image branch December 8, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: enhancement A request for an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants