Remove auxiliaryButtonImage from CardPresentModalScanningForReader
#8333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported on #8312 (comment)
Description
This PR removes the
auxiliaryButtonimageproperty fromCardPresentModalScanningForReaderwhich outputs a(¡)image along the button's text on different modal views through the CardPresent flow.Context
With the usage of the new UIButton configuration API we have found some conflicts in the way we're dealing with button content configuration through this flow, in this case we have opted for removing the image temporarily as was the source of different design glitches.
We have opened a related issue to keep track of it, and restore the image in the future, when we migrate the modals to SwiftUI and apply the new button configuration API.
Changes
auxiliaryButtonimagepropertyUIButton.Configurationwhen styling the buttonTesting instructions
Learn More about In-Person Paymentsbutton. This is more easily checked by commenting outdiscoveredReadersSubject.send(wooReaders)here, so the flow doesn't move forward to the next step.Cancelbutton when the app prompts to connect a reader.I'd left out of this PR further improvements like moving button
titleandattributedTitleto the button configuration because this needs more extensive testing. These are left to be done along this issue.