Analytics Hub: Decouple ranges #8401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8340
Why
We found out that using a single enum for the analytics hub ranges was not ideal because the UI and the business logic had slightly different requirements that forced us to write code that was not very readable.
To mitigate this, this PR is decoupling that situation by adding a new
Rangeenum just meant for the view.As this enum needs some metadata from the original
SelectionType, I've extracted that into a newAnalyticsHubRangeAdaptertype that helps the conversions between those two and contains the shared data.The
AnalyticsHubRangeAdapteris a bit verbose and looks like it's duplicating work but keeps the complexity contained and we gain things like:Demo
Screen.Recording.2022-12-13.at.11.35.34.PM.mov
Testing Steps
RELEASE-NOTES.txtif necessary.