Skip to content

REST API: Update coupon mappers to support REST API #8416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 20 commits into from
Closed

REST API: Update coupon mappers to support REST API #8416

wants to merge 20 commits into from

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Dec 15, 2022 •
edited
Loading

Part of #8390
⚠️ This PR depends on #8402 so please make sure to merge that first ⚠️

Description

This PR updates CouponListMapper and CouponMapper to parse coupons regardless of whether the data envelope is present in the response.

Testing instructions

  • Navigate to Menu > Coupons. If the option is unavailable, navigate to Settings > Experimental Features > Enable coupon management.
  • Notice that the coupon list is loaded properly.
  • Try searching, creating, editing, deleting coupons. Everything should work as before.

Screenshots

N/A

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo
Inject siteID from DefaultStoresManager to AlamofireNetwork
7895ade
@itsmeichigo
Add new request type for REST API requests
0099895
@itsmeichigo
Configure application password use case in AlamofireNetwork
3efefba
@itsmeichigo
Add new method to update headers for REST requests
f4e1519
@itsmeichigo
Update AlamofireNetwork to handle application password
823607a
@itsmeichigo
Use Task only for fetching application password
583d756
@itsmeichigo
Add a fallback Jetpack request to REST request to trigger when applic…
763ba7f 
…ation password is blocked
@itsmeichigo
Fix line limit violation
168a6ac
@itsmeichigo
Update comment for RESTRequest initializer
9b0d019
@itsmeichigo
Inject the complete use case to AlamofireNetwork from AuthenticatedState
17cae6a
@itsmeichigo
Update comments for AlamofireNetwork
5e07911
@itsmeichigo
Revert "Inject the complete use case to AlamofireNetwork from Authent…
85c31f8 
…icatedState"

This reverts commit 17cae6a.
@itsmeichigo
Separate authentication logic to a new class
9740cbb
@itsmeichigo
Make ApplicationPasswordUseCase injectable
cc87a50
@itsmeichigo
Add unit tests for RequestAuthenticator
ad69556
@itsmeichigo
Update comments for RESTRequest
4b5423e
@itsmeichigo
Fix incorrect username and password when authenticating rest request
3ede699
@itsmeichigo
Reformat code for RequestAuthenticator
d1ea84c
@itsmeichigo
Update coupon mappers to support response without data envelope
5afc7d7
@itsmeichigo
Rename mock json file
9e02521
@itsmeichigo itsmeichigo added type: task An internally driven task. feature: coupons Related to basic fulfillment such as order tracking. labels Dec 15, 2022
@itsmeichigo itsmeichigo marked this pull request as ready for review December 15, 2022 08:59
@peril-woocommerce
Copy link

peril-woocommerce bot commented Dec 15, 2022

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 15, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8416-9e02521 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@selanthiraiyan selanthiraiyan self-assigned this Dec 16, 2022
selanthiraiyan
selanthiraiyan approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@itsmeichigo itsmeichigo changed the base branch from feat/8389-network-update-for-rest-api to trunk December 16, 2022 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaclync jaclync Awaiting requested review from jaclync

1 more reviewer

@selanthiraiyan selanthiraiyan selanthiraiyan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@selanthiraiyan selanthiraiyan

Labels

feature: coupons Related to basic fulfillment such as order tracking. type: task An internally driven task.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@itsmeichigo @wpmobilebot @selanthiraiyan