Skip to content

Add missing networking_pods dependencies to Yosemite in Podfile #8418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Add missing networking_pods dependencies to Yosemite in Podfile #8418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,21 @@ def stripe_terminal
pod 'StripeTerminal', '~> 2.14'
end

def networking_pods
alamofire
cocoa_lumberjack

pod 'Sourcery', '~> 1.0.3', configuration: 'Debug'

# Used for HTML parsing
aztec

# Used for storing application password
keychain

wordpress_kit
end

# Main Target!
# ============
#
Expand Down Expand Up @@ -122,6 +137,7 @@ def yosemite_pods
stripe_terminal
cocoa_lumberjack
wordpress_kit
networking_pods
Copy link
Contributor Author

@mokagio mokagio Dec 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the PR description I wrote "Yosemite depends on Networking (e.g. in Store.swift) but the dependency was never explicit in the Podfile".

This change doesn't make the dependency explicit either, to be fair, but is close enough. On the top of my mind, I'm not sure whether we can make one target depend on another with our multiple projects setup. I don't think it's worth spending additional time on this right now because we may be migrating away from CocoaPods soon-ish. So, as long as the app builds, we're good.

Copy link
Contributor

@AliSoftware AliSoftware Dec 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, I think it would be possible to do it by using abstract_target. But I agree it's not worth spending the time.


aztec
end
Expand Down Expand Up @@ -165,24 +181,6 @@ target 'WooFoundationTests' do
woofoundation_pods
end

# Networking Layer:
# =================
#
def networking_pods
alamofire
cocoa_lumberjack

pod 'Sourcery', '~> 1.0.3', configuration: 'Debug'

# Used for HTML parsing
aztec

# Used for storing application password
keychain

wordpress_kit
end

# Networking Target:
# ==================
#
Expand Down
2 changes: 1 addition & 1 deletion Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,6 @@ SPEC CHECKSUMS:
ZendeskSupportProvidersSDK: 2bdf8544f7cd0fd4c002546f5704b813845beb2a
ZendeskSupportSDK: 3a8e508ab1d9dd22dc038df6c694466414e037ba

PODFILE CHECKSUM: 04b17163281ec1c5967ef28a56f130d10c73bce9
PODFILE CHECKSUM: 670bb1b07306bd212f79b8afb1ebed4fc6eaa7b7

COCOAPODS: 1.11.3