Skip to content

[Analytics Hub] Release Sessions card and remove feature flag #8428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 16, 2022
Merged

[Analytics Hub] Release Sessions card and remove feature flag #8428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6bff181
Release all Analytics Hub features
rachelmcr Dec 15, 2022
61bfa25
Update release notes
rachelmcr Dec 15, 2022
603e7fe
Merge branch 'trunk' into issue/8324-release-sessions-card
rachelmcr Dec 16, 2022
411a4f8
Merge branch 'trunk' into issue/8324-release-sessions-card
rachelmcr Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Experiments/Experiments/DefaultFeatureFlagService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
.performanceMonitoringUserInteraction:
// Disabled by default to avoid costs spikes, unless in internal testing builds.
return buildConfig == .alpha
case .analyticsHub:
return buildConfig == .localDeveloper || buildConfig == .alpha
case .tapToPayOnIPhone:
return buildConfig == .localDeveloper
default:
Expand Down
4 changes: 0 additions & 4 deletions Experiments/Experiments/FeatureFlag.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,4 @@ public enum FeatureFlag: Int {
///
/// - Note: The app will ignore this if `performanceMonitoring` is `false`.
case performanceMonitoringViewController

/// Temporary feature flag for the native Jetpack setup flow.
///
case analyticsHub
}
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
11.7
-----
- [**] Analytics Hub: Now you can select custom date ranges. [https://github.com/woocommerce/woocommerce-ios/pull/8414]
- [**] Analytics Hub: Now you can see Views and Conversion Rate analytics in the new Sessions card. [https://github.com/woocommerce/woocommerce-ios/pull/8428]
- [*] My Store: We fixed an issue with Visitors and Conversion stats where sometimes visitors could be counted more than once in the selected period. [https://github.com/woocommerce/woocommerce-ios/pull/8427]


Expand Down
2 changes: 1 addition & 1 deletion WooCommerce/Classes/ViewRelated/Dashboard/Analytics Hub/AnalyticsHubView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ struct AnalyticsHubView: View {

Divider()
}
.renderedIf(ServiceLocator.featureFlagService.isFeatureFlagEnabled(.analyticsHub) && viewModel.showSessionsCard)
.renderedIf(viewModel.showSessionsCard)

Spacer()
}
Expand Down