-
Notifications
You must be signed in to change notification settings - Fork 121
Store creation M3: profiler question - optional selling platforms #8497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e selling platform selector.
…ing status followup question.
…create a container view to conditionally show the selling status or platforms question.
…hen using `LazyNavigationLink` for the followup platforms question.
You can test the changes from this Pull Request by:
|
selanthiraiyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
|
|
||
| /// Question content. | ||
| /// TODO: 8376 - update values when API is ready. | ||
| let platforms: [Platform] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: If we will always use all the cases from Platform we could make Platform confirm to CaseIterable and use let platforms = Platform.allCases here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great suggestion! it looks like allCases follows the order of the case declarations so that's good for the use case. updated in 153cb15
…CaseIterable` conformance.
Part of #8377
Description
This PR only includes the UI part, as the API is still WIP (p1670825052838929/1670823717.177509-slack-C01SFMVEYAK). The profiler question is only shown behind a new feature flag
storeCreationM3Profiler, and the selected option isn't shown in the store summary screen so the value doesn't need to be passed to subsequent view controllers.After the main question about the selling status in #8481, this PR implemented the follow-up question on the eCommerce platforms for merchants who indicate that they're already selling online. A new SwiftUI
StoreCreationSellingPlatformsQuestionViewwas created for the platforms question. The first selling status question viewStoreCreationSellingStatusQuestionViewwas refactored to just contain the selling status question content, and a new container viewStoreCreationSellingStatusQuestionContainerViewwas created to show either the platforms question or the selling status question based on the view model'sisAlreadySellingOnlineboolean.Another navigation implementation I tried
First I tried navigating to the platforms question view from the main selling status question view using
LazyNavigationLink/NavigationLink, but a new issue on the navigation bar background appeared. The background color of the navigation bar is set to the default color instead of the custom transparent color set in the hosting controller. The API to configure the navigation bar color in SwiftUI is only available in iOS 16+, while our app still supports iOS 15.Testing instructions
Switch store+ Add a storeCreate a new store--> the store name form should be shownSkip--> the domain selector should be shownContinue--> the domain selector should be shownContinue--> the domain selector should be shownScreenshots
RELEASE-NOTES.txtif necessary.