Variations: Generates all variations locally #8537
Conversation
Ecarrion
added
the
feature: variation list
You can test the changes from this Pull Request by:
|
There was a problem hiding this comment.
Works well! 
I've noticed one visual nit that may disappear in further development: when action is triggered, whole variation list blinks with empty state (no existing variations, no "•••" button) before reappearing again. It's very quick transition, but I can always reproduce it.
| ProductVariationAttribute(id: option.attributeID, name: option.attributeName, option: option.value) | ||
| } | ||
| // Setting a regular price is not required when creating a variation. | ||
| return CreateProductVariation(regularPrice: "", attributes: attributes) |
There was a problem hiding this comment.
nit: updating initializer to have empty string as a default value for regularPrice can improve readability.
Nice catch, this happens because when resyncing variations the current ones are deleted. I'll make sure to handle this! |
closes: #8488
Why
This PR adds a
ProductVariationGeneratortype that is in charge to generate all possible variations from product attributes. Additionally, it excludes any provided existing variation from the combination list.How
Adds a
ProductVariationGeneratortype that creates all possible variations. Internally it uses the cartesian product algorithm to generate combinations. Mainly copied from our android counterpart.Integrates the generator on
ProductVariationsViewModel, and outputs the number of variations to generate in the console. Variation creation will be shipped on a different PR.Testing Steps
RELEASE-NOTES.txtif necessary.