REST API: Migrate orders endpoint #8554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmeichigo
added
type: task
Collaborator
You can test the changes from this Pull Request by:
|
Generated by 🚫 dangerJS |
jaclync
approved these changes
Jan 6, 2023
Contributor
jaclync
left a comment
jaclync
left a comment
There was a problem hiding this comment.
LGTM 
there are some failures from related entities like refunds, products, and countries, I'm sure they will be handled separately.
| return mapOrders(from: "orders-load-all") | ||
| } | ||
|
|
||
| /// Returns the OrderListMapper output upon receiving `orders-load-all-without-data` |
Contributor
There was a problem hiding this comment.
super nit:
Suggested change
| /// Returns the OrderListMapper output upon receiving `orders-load-all-without-data` | |
| /// Returns the [Order] output upon receiving `orders-load-all-without-data` |
| return mapOrder(from: "order") | ||
| } | ||
|
|
||
| /// Returns the OrderMapper output upon receiving `order-without-data` |
Contributor
There was a problem hiding this comment.
super nit:
Suggested change
| /// Returns the OrderMapper output upon receiving `order-without-data` | |
| /// Returns the Order output upon receiving `order-without-data` |
| return mapNotes(from: "order-notes") | ||
| } | ||
|
|
||
| /// Returns the OrderNotesMapper output upon receiving `order-notes-without-data` |
Contributor
There was a problem hiding this comment.
super nit:
Suggested change
| /// Returns the OrderNotesMapper output upon receiving `order-notes-without-data` | |
| /// Returns the [OrderNote] output upon receiving `order-notes-without-data` |
| let statuses = try? mapper.map(response: data) | ||
|
|
||
| // Then | ||
| XCTAssertNotNil(mapper) |
Contributor
There was a problem hiding this comment.
any reasons asserting on the mapper? the mapper initialization doesn't seem nullable 🤔
Contributor
Author
There was a problem hiding this comment.
This is redundant indeed 😅 Removed in 6dad597.
| } | ||
|
|
||
| // When | ||
| let statuses = try? mapper.map(response: data) |
Contributor
There was a problem hiding this comment.
nit: can probably make the result non-nil by using try XCTUnwrap
| private extension ReportOrderTotalsMapperTests { | ||
| /// Returns the CustomerMapper output upon receiving `filename` (Data Encoded) | ||
| /// | ||
| func mapStatus(from filename: String) throws -> [OrderStatus] { |
Contributor
There was a problem hiding this comment.
nit: is this meant to be used?
Contributor
Author
There was a problem hiding this comment.
This is also redundant - removed in 2f9d67d 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8550
Description
This PR updates all mappers related to orders endpoints:
ReportOrderTotalsMapper,OrderListMapper,OrderMapper,OrderNoteMapperto parse contents without the data envelope.All endpoints with paths
/orders,/notesand/reports/orders/totalsare enabled for REST API requests.Testing instructions
applicationPasswordAuthenticationForSiteCredentialLoginand build the app.Please feel free to test again by logging in with a WPCom account. All order-related features should work too.
Screenshots
N/A
RELEASE-NOTES.txtif necessary.