Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jan 6, 2023

Closes: #8568

Description

This PR migrates the refund endpoints with the following changes:

  • Updated the RefundMapper and RefundListMapper to parse contents without the data envelope.
  • Enabled REST API on all refund endpoints.

Testing instructions

  • Enable the feature flag applicationPasswordAuthenticationForSiteCredentialLogin and build the app.
  • Log out of the app or skip onboarding if needed.
  • On the prologue screen, select "Enter your site address".
  • Enter the address of your self-hosted site and proceed to log in with site credentials.
  • After logging in, navigate to the Orders tab. Select an existing order or create a new one if needed.
  • Update the order status to "Completed", then select "Issue Refund" on the order detail screen.
  • Create a refund for the order. Notice that the creation succeeds.
  • Navigate back to the order list and select the order again. Notice that the created refund is listed in the order detail screen.
  • Select the refund to see its detail. Notice that the detail can be loaded correctly.

Please feel free to test again by logging in to a WP.com account. The refund feature should still work correctly.

Screenshots

N/A


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: refunds Related to order refunds. feature: REST API Authenticating requests using application password and using REST API instead of Jetpack tunnel. labels Jan 6, 2023
@itsmeichigo itsmeichigo force-pushed the feat/8568-refund-migrate branch from 15f55a6 to 99e9656 Compare January 6, 2023 06:37
@itsmeichigo itsmeichigo changed the base branch from trunk to feat/8550-orders-migrate January 6, 2023 06:38
@itsmeichigo itsmeichigo marked this pull request as ready for review January 6, 2023 06:48
@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8569-99e9656 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@selanthiraiyan selanthiraiyan self-assigned this Jan 6, 2023
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Base automatically changed from feat/8550-orders-migrate to trunk January 9, 2023 02:46
@peril-woocommerce
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@itsmeichigo itsmeichigo merged commit 16e118f into trunk Jan 9, 2023
@itsmeichigo itsmeichigo deleted the feat/8568-refund-migrate branch January 9, 2023 03:17
@itsmeichigo itsmeichigo added this to the 11.9 milestone Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: refunds Related to order refunds. feature: REST API Authenticating requests using application password and using REST API instead of Jetpack tunnel. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

REST API: Migrate refund endpoints

4 participants