Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jan 9, 2023

Closes: #8583

Description

This PR continues the migration work for REST API:

  • Updated the CountryListMapper to parse content without the data envelope
  • Enable REST API on the country list fetch endpoint.

Testing instructions

  • Enable the feature flag applicationPasswordAuthenticationForSiteCredentialLogin and build the app.
  • Log out of the app or skip onboarding if needed.
  • On the prologue screen, select "Enter your site address" and enter the address of your self-hosted store.
  • Proceed to login with site credentials.
  • After the login succeeds, you should be navigated to the home screen.
  • Select the Orders tab and tap "+" to add a new order.
  • On the order creation form, select "Add Customer Details" > "Country" to add a country for the user.
  • Notice that the country list is loaded properly.

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: REST API Authenticating requests using application password and using REST API instead of Jetpack tunnel. labels Jan 9, 2023
@itsmeichigo itsmeichigo added this to the 11.9 milestone Jan 9, 2023
@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8584-dd154de on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@selanthiraiyan selanthiraiyan self-assigned this Jan 9, 2023
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@itsmeichigo itsmeichigo merged commit ed6470e into trunk Jan 9, 2023
@itsmeichigo itsmeichigo deleted the feat/8583 branch January 9, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: REST API Authenticating requests using application password and using REST API instead of Jetpack tunnel. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

REST Request: Migrate country endpoint

4 participants