Skip to content

Conversation

@jaclync
Copy link
Contributor

@jaclync jaclync commented Jan 10, 2023

Temporarily for #8221

Description

We've tried a few ways to fix two flaky tests that call InAppPurchaseAction.userIsEntitledToProduct, but haven't found a fix yet that can pass consistently when running the same test cases several times #8256 (review). Let's disable them for now and come up with a way to make them pass consistently, possibly when we're going to launch IAP. This helps us unblock PR merging and save CI resources.

Testing instructions

Just CI.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jaclync jaclync added the category: unit tests Related to unit testing. label Jan 10, 2023
@jaclync jaclync added this to the 11.9 milestone Jan 10, 2023
@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8599-11371f6 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@iamgabrielma iamgabrielma self-assigned this Jan 10, 2023
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@jaclync jaclync merged commit 1f4fddf into trunk Jan 10, 2023
@jaclync jaclync deleted the task/disable-flaky-InAppPurchaseStoreTests-test branch January 10, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: unit tests Related to unit testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants