Domain settings: show a list of domains with a CTA to add a domain #8606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
You can test the changes from this Pull Request by:
|
* trunk: Fix build errors. Networking layer changes for 2 domain settings endpoints.
* trunk: (79 commits) Updated copyright year Bump version number Update metadata translations Update app translations – `Localizable.strings` Correct title in the Payments Menu Fix bug where variation count was duplicated Update EditAttributesViewModel.swift 8627 Add manual link fixes to the 11.9 release 8627 Update card reader manual URLs 8622 8621 Add metadata to payment intent for TTPoI Update documentation for Today and `to date` ranges Adjust formatting operations for date ranges Remove commented code Adds changelog Removes genereateAllVariation feature flag Fix contentEdgeInsets deprecation warnings Show action sheet/popover with bulk edit options Improve string descriptions Add disabled state for link button style Enabled bulk edit button conditionally ...
1 task
itsmeichigo
approved these changes
Jan 16, 2023
| static let domainPadding: EdgeInsets = .init(top: 10, leading: 16, bottom: 10, trailing: 16) | ||
| static let actionButtonPadding: EdgeInsets = .init(top: 18, leading: 16, bottom: 18, trailing: 23) | ||
| static let dividerPadding: EdgeInsets = .init(top: 0, leading: 16, bottom: 0, trailing: 0) | ||
| static let dividerHeight: CGFloat = 1 |
Contributor
There was a problem hiding this comment.
Super nit: this doesn't seem to be used, should we remove it?
| .captionStyle() | ||
|
|
||
| ForEach(domains, id: \.name) { domain in | ||
| HStack { |
Contributor
There was a problem hiding this comment.
❓ Are we planning to add some button on the right side of the item? Asking because I'm not sure why we need a HStack to embed the contents here.
Contributor
Author
There was a problem hiding this comment.
Good question, we don't plan to add any button to the trailing side. Originally it was the only straightforward way for me to align the domain rows on the trailing edge, however it doesn't look needed anymore. Removed in 5ba1ff5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8558
Description
When there are non-zero domains other than the free staging domain, a list of domains should be shown with a link button to add a domain. This PR just contains the UI changes to show the domain list.
Testing instructions
The UI is still using mock data, you can test the SwiftUI previews so that a domain list is shown when there are non-empty domains.
Screenshots
RELEASE-NOTES.txtif necessary.