Bulk Editing: Add bottom toolbar to the products list #8617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealeksandrov
added
feature: product list
Generated by 🚫 dangerJS |
5 tasks
Collaborator
You can test the changes from this Pull Request by:
|
Ecarrion
approved these changes
Jan 12, 2023
Contributor
Ecarrion
left a comment
Ecarrion
left a comment
There was a problem hiding this comment.
Looks good!
Maybe it's worth adding an issue about the bar in landscape as it feels weird the transition between the tab bar and the bottom toolbar.
Comment on lines
+562
to
+567
| // trigger safe area update | ||
| if let tabBarController { | ||
| let currentFrame = tabBarController.view.frame | ||
| tabBarController.view.frame = currentFrame.insetBy(dx: 0, dy: 1) | ||
| tabBarController.view.frame = currentFrame | ||
| } |
Contributor
There was a problem hiding this comment.
Nice trick, maybe we can wrap this in a small extension helper!
Contributor
Author
There was a problem hiding this comment.
I'll keep it inline for now and hope safe areas will "just work" going forward 🙂
But feel free to convert it to extension if you spot similar issue in other views.
Contributor
Author
|
Thanks for review!
You mean transition between full-screen width and table/stack width, right? Created #8625 for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8517
Description
This PR adds bottom toolbar with bulk edit button on Products List.
It replaces tabbar. Action button is enabled conditionally when items are selected.
Note: toolbar is custom and embedded in the stackview, so in landscape mode it doesn't fill full width and doesn't have compact height. It's same as top existing toolbar, but may feel different from system toolbars. We can update the layout later if needed.
Testing
Screenshots
RELEASE-NOTES.txtif necessary.