Skip to content

Variations: Remove feature flag #8619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 13, 2023
Merged

Variations: Remove feature flag #8619

merged 4 commits into from
Jan 13, 2023

Conversation

@Ecarrion
Copy link
Contributor

@Ecarrion Ecarrion commented Jan 12, 2023 •
edited
Loading

Closes: #8494

Why

This PR removes the generateAllVariations feature flag in order to release the feature on the 11.9 version.

Test Plan

pe5pgL-1KE-p2

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 12, 2023 •
edited
Loading

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8619-6fd8a1a on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@Ecarrion Ecarrion added this to the 11.9 milestone Jan 12, 2023
@Ecarrion Ecarrion requested review from ealeksandrov, itsmeichigo and rachelmcr and removed request for itsmeichigo January 12, 2023 17:26
@Ecarrion Ecarrion added the feature: variation list Related to the variations list for variable products. label Jan 12, 2023
@Ecarrion Ecarrion linked an issue Jan 12, 2023 that may be closed by this pull request
Variations: Remove Feature flag #8494
Closed
@Ecarrion Ecarrion marked this pull request as ready for review January 12, 2023 17:27
@rachelmcr rachelmcr self-assigned this Jan 13, 2023
Base automatically changed from issue/8493-tracks to trunk January 13, 2023 14:38
@peril-woocommerce
Copy link

peril-woocommerce bot commented Jan 13, 2023

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@Ecarrion Ecarrion merged commit 51d0fac into trunk Jan 13, 2023
@Ecarrion Ecarrion deleted the issue/8494-remove-feature-flag branch January 13, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ealeksandrov ealeksandrov Awaiting requested review from ealeksandrov

1 more reviewer

@rachelmcr rachelmcr rachelmcr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rachelmcr rachelmcr

Labels

feature: variation list Related to the variations list for variable products.

Projects

None yet

Milestone

11.9

Development

Successfully merging this pull request may close these issues.

Variations: Remove Feature flag

4 participants

@Ecarrion @wpmobilebot @rachelmcr