Skip to content

[Mobile Payments] Add metadata to payment intent for TTPoI #8626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2023
Merged

[Mobile Payments] Add metadata to payment intent for TTPoI #8626

merged 1 commit into from
Jan 13, 2023

Conversation

@joshheald
Copy link
Contributor

@joshheald joshheald commented Jan 13, 2023 •
edited
Loading

Closes: #8622
Closes: #8621

Description

This PR adds the platform metadata key, so we can distinguish transactions made using TTPoI and TTP on Android.

Android uses reader_model: COTS_DEVICE for built-in reader payments, so we also update to use that for consistency.

Testing instructions

Take a payment using Tap to Pay on iPhone
Log in to the Stripe dashboard and find the transaction
Observe that the metadata includes reader_model: COTS_DEVICE and platform: ios

Screenshots

CleanShot 2023-01-13 at 12 07 46@2x

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@joshheald joshheald added type: task An internally driven task. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. labels Jan 13, 2023
@joshheald joshheald marked this pull request as ready for review January 13, 2023 12:18
@joshheald joshheald requested a review from toupper January 13, 2023 12:19
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 13, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8626-9f714bb on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@toupper toupper self-assigned this Jan 13, 2023
@toupper
Copy link
Contributor

toupper commented Jan 13, 2023

LGTM :shipit:

@joshheald joshheald added this to the 11.9 milestone Jan 13, 2023
@joshheald joshheald merged commit 7b99dd6 into trunk Jan 13, 2023
@joshheald joshheald deleted the issue/8622-metadata branch January 13, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toupper toupper toupper approved these changes

Assignees

@toupper toupper

Labels

feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: task An internally driven task.

Projects

None yet

Milestone

11.9

Development

Successfully merging this pull request may close these issues.

[Mobile Payments] Add platform: iOS metadata to PaymentIntent [Mobile Payments] Update reader type for built in reader to COTS_DEVICE

4 participants

@joshheald @wpmobilebot @toupper