Domain selector for paid domains: Networking layer changes #8642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd domain products for the price info.
…dDomainProducts`.
Collaborator
You can test the changes from this Pull Request by:
|
…h-networking * feat/8558-domain-list: (79 commits) Updated copyright year Bump version number Update metadata translations Update app translations – `Localizable.strings` Correct title in the Payments Menu Fix bug where variation count was duplicated Update EditAttributesViewModel.swift 8627 Add manual link fixes to the 11.9 release 8627 Update card reader manual URLs 8622 8621 Add metadata to payment intent for TTPoI Update documentation for Today and `to date` ranges Adjust formatting operations for date ranges Remove commented code Adds changelog Removes genereateAllVariation feature flag Fix contentEdgeInsets deprecation warnings Show action sheet/popover with bulk edit options Improve string descriptions Add disabled state for link button style Enabled bulk edit button conditionally ...
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8558
Based on #8606, please review this first
Description
This PR includes the Networking layer changes for the domain selector from domain settings, where a merchant can choose a paid domain for the production version of their store. In order to show a list of paid domain suggestions, two remote calls are added to
DomainRemoteProtocol:loadFreeDomainSuggestions(query:): loads paid domain suggestions based on the query. since the response is in a different format from the free domain suggestions, a new function is added with a new response modelPaidDomainSuggestionloadDomainProducts: loads all the WPCOM domain products so that we can show the domain price info for suggestions inloadPaidDomainSuggestionswith a new response modelDomainProductTesting instructions
Just CI, as the networking layer changes aren't integrated yet.
RELEASE-NOTES.txtif necessary.