Skip to content

Domain selector for paid domains: Yosemite layer changes #8660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

Domain selector for paid domains: Yosemite layer changes #8660

merged 1 commit into from
Jan 18, 2023

Conversation

@jaclync
Copy link
Contributor

@jaclync jaclync commented Jan 17, 2023

Part of #8558

Description

This PR includes the Yosemite layer changes for the domain selector from domain settings, where a merchant can choose a paid domain before publishing their store. In order to show a list of paid domain suggestions, two remote calls are required from the previous networking layer changes #8642.

A new action DomainAction.loadPaidDomainSuggestions was added to load domain products & suggestions at the same time, then return the domain suggestions PaidDomainSuggestion with the price info.

Testing instructions

Just CI, as the Yosemite action isn't integrated yet.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jaclync
Implement DomainAction.loadPaidDomainSuggestions to load domain sug…
9daeca0 
…gestions and products for paid domain selector.
@jaclync jaclync added the type: task An internally driven task. label Jan 17, 2023
@jaclync jaclync added this to the 12.0 milestone Jan 17, 2023
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 17, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8660-9daeca0 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

This was referenced Jan 17, 2023
Merged
Open
@itsmeichigo itsmeichigo self-assigned this Jan 17, 2023
itsmeichigo
itsmeichigo approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@jaclync jaclync merged commit dc3ddc9 into trunk Jan 18, 2023
@jaclync jaclync deleted the feat/8558-domain-selector-yosemite branch January 18, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

@selanthiraiyan selanthiraiyan Awaiting requested review from selanthiraiyan

Assignees

@itsmeichigo itsmeichigo

Labels

type: task An internally driven task.

Projects

None yet

Milestone

12.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jaclync @wpmobilebot @itsmeichigo