-
Notifications
You must be signed in to change notification settings - Fork 121
Migrate the telemetry endpoint to use REST API #8647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can test the changes from this Pull Request by:
|
jaclync
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ![]()
| siteID: siteID, | ||
| path: path, | ||
| parameters: parameters, | ||
| availableAsRESTRequest: true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to also add test cases for TelemetryRemoteTests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a new case in 3c3e415.
Closes: #8646
Description
This PR continues the REST API migration work by enabling the send telemetry endpoint to use the REST API.
Testing instructions
Pre-requisite: due to a rate-limit issue with Pressable sites, create a JN site to ensure that testing is smooth for now.
applicationPasswordAuthenticationForSiteCredentialLoginand build the app.Successfully sent telemetry for siteID(unless throttled).Screenshots
N/A
RELEASE-NOTES.txtif necessary.