Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jan 16, 2023

Closes: #8646

Description

This PR continues the REST API migration work by enabling the send telemetry endpoint to use the REST API.

Testing instructions

Pre-requisite: due to a rate-limit issue with Pressable sites, create a JN site to ensure that testing is smooth for now.

  • Enable feature flag applicationPasswordAuthenticationForSiteCredentialLogin and build the app.
  • Log out of the app or skip onboarding if needed.
  • On the prologue screen, select Enter your site address and enter the address of your self-hosted site.
  • Proceed to log in with site credentials.
  • When the login succeeds, you should see the home screen.
  • Suppose your test store has Woo version >= 5.9.0, you should be able to see a log in the Xcode console: Successfully sent telemetry for siteID (unless throttled).
  • Please feel free to install Woo version < 5.9.0 and repeat the steps above. Telemetry API is not available for these versions so the request should not be made.

Screenshots

N/A


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: REST API Authenticating requests using application password and using REST API instead of Jetpack tunnel. labels Jan 16, 2023
@itsmeichigo itsmeichigo added this to the 12.0 milestone Jan 16, 2023
@itsmeichigo itsmeichigo marked this pull request as ready for review January 16, 2023 11:30
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 16, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8647-3c3e415 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@jaclync jaclync self-assigned this Jan 17, 2023
Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

siteID: siteID,
path: path,
parameters: parameters,
availableAsRESTRequest: true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to also add test cases for TelemetryRemoteTests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a new case in 3c3e415.

@itsmeichigo itsmeichigo enabled auto-merge January 17, 2023 05:08
@itsmeichigo itsmeichigo merged commit 02ed2e2 into trunk Jan 17, 2023
@itsmeichigo itsmeichigo deleted the feat/8646-telemetry-migration branch January 17, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: REST API Authenticating requests using application password and using REST API instead of Jetpack tunnel. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

REST API: Migrate Telemetry endpoint

4 participants