Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

Part of #8453

Description

This PR updates the push notification setup logic by skipping the setup if the user is authenticated without WPCom.

Testing instructions

  • Delete the app on your physical device if it's already installed.
  • Turn on the feature flag applicationPasswordAuthenticationForSiteCredentialLogin and build the app to the device.
  • Log out of the app or skip onboarding if needed.
  • On the prologue screen, select Enter your site address and proceed with the address of your self-hosted site.
  • Log in with your site credentials.
  • After the login succeeds, you should be navigated to the home screen. There should be no alert for push notification permission. Neither of the methods didRegisterForRemoteNotificationsWithDeviceToken and didFailToRegisterForRemoteNotificationsWithError on AppDelegate should be triggered.

Screenshots

N/A


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: REST API Authenticating requests using application password and using REST API instead of Jetpack tunnel. labels Jan 17, 2023
@itsmeichigo itsmeichigo added this to the 12.0 milestone Jan 17, 2023
@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8665-07101d8 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@selanthiraiyan selanthiraiyan self-assigned this Jan 18, 2023
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected. 🚢

@itsmeichigo itsmeichigo merged commit 16172ce into trunk Jan 18, 2023
@itsmeichigo itsmeichigo deleted the feat/8453-hide-unsupported-ui branch January 18, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: REST API Authenticating requests using application password and using REST API instead of Jetpack tunnel. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants