-
Notifications
You must be signed in to change notification settings - Fork 121
Bulk Editing: Add price picker #8691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 dangerJS |
You can test the changes from this Pull Request by:
|
Ecarrion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR was a bit big but the changes were straightforward and easy to review!
One thing I noted is that variations prices can't be bulk updated, how do we plan to handle that scenario?
|
Thanks, I agree that it could be split into more manageable parts 😅
We have #8577, I'll add it before releasing the feature. |
Closes: #8520
Description
This PR adds status selector for bulk editing on Products List. Networking action is connected, loading, success and error states implemented.
How
UI is based on
BulkUpdatePriceViewControllerthat is used for bulk variations update.PriceInputViewControlleris mostly the same, but stripped of networking actions and variation logic. In future we can unify them by adding some coordinator/subclass for variations.Testing
Video
Simulator.mp4
RELEASE-NOTES.txtif necessary.