Skip to content

Test draft branch for CI #8812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 25 commits into from
Closed

Test draft branch for CI #8812

wants to merge 25 commits into from

Conversation

@toupper
Copy link
Contributor

@toupper toupper commented Feb 2, 2023

Closes: #

Description

This branch is not intended to be merged. We want to make sure that CI build and tests run successfully before merging #8806 into the release.

Testing instructions

Screenshots

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

selanthiraiyan and others added 25 commits February 1, 2023 17:49
@selanthiraiyan
Introduce ABTestVariationProvider for reading ABTest from Woo layer.
5a9608e
@selanthiraiyan
AuthenticationManager - Inject ABTestVariationProvider and use it…
b8868f1 
… for reading ABTest.
@selanthiraiyan
AppCoordinator - Inject ABTestVariationProvider and use it for re…
3813dc4 
…ading ABTest.
@selanthiraiyan
AppCoordinator - Inject ABTestVariationProvider and use it for re…
1c5fdc8 
…ading ABTest.
@selanthiraiyan
Inject ABTest variation from unit tests.
c3414ad
@selanthiraiyan
Stop having variation as public to force usage of `ABTestVariationP…
66a0321 
…rovider`.
@selanthiraiyan
Unit test the REST API AB test tracks event value.
0033332
@selanthiraiyan
Move MockABTestVariationProvider to a separate file for reusability.
4e7535e
@selanthiraiyan
Update unit test name to reflect the actual test.
5ae2cda
@selanthiraiyan
Add unit tests to check the scenarios when application password authe…
b4b1582 
…ntication is turned on.
@selanthiraiyan
Make ABTest confirm to Codable to store it to disk
0c32dd1
@selanthiraiyan
Introduce VariationCache to store the ABTest variation information …
7c5a5cf 
…to disk.
@selanthiraiyan
Add cached implementation of ABTestVariationProvider
ada4aa6
@selanthiraiyan
Point Automattic tracks pod to beta version.
f9107f3
@selanthiraiyan
ABTest - Return nil instead of assuming control as variation.
99b0953
@selanthiraiyan
Add ExperimentsTests to unit test plan.
dcca964
@selanthiraiyan
Start using CachedABTestVariationProvider instead of `DefaultABTest…
9803a25 
…VariationProvider`
@selanthiraiyan
Point tracks pod to latest beta commit.
8908527
@selanthiraiyan
Use Mock ABTest values for unit testing.
e0d9ee5
@selanthiraiyan
Explain why we cache only logged out experiments.
c4ce4ca
@selanthiraiyan
Avoid sending mock ABTest cases to server.
737ee32
@selanthiraiyan
Give preference to remote value over cached value.
c0708bf
@selanthiraiyan
Point Automattic-Tracks-iOS to latest beta version.
40c08c3
@selanthiraiyan
Update podfile.lock.
527373f
@toupper
Merge branch 'bugfix/8782-cache-logged-out-ab-tests' into task/test-d…
4735cc4 
…raft-branch
@peril-woocommerce
Copy link

peril-woocommerce bot commented Feb 2, 2023 •
edited
Loading

Fails
🚫 This PR is tagged with 'status: do not merge' label.

Generated by 🚫 dangerJS

@toupper toupper added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Feb 2, 2023
@toupper toupper marked this pull request as draft February 2, 2023 15:33
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 2, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8812-4735cc4 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@malinajirka
Copy link
Contributor

malinajirka commented Feb 2, 2023

Thanks for creating this test/draft PR!

Seems like CI is happy, so the changes which were unintentionally merged directly into release/12.1 are working as expected with the automated tests.

@malinajirka malinajirka closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: do not merge Dependent on another PR, ready for review but not ready for merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@toupper @wpmobilebot @malinajirka @selanthiraiyan