Skip to content

Conversation

@rachelmcr
Copy link
Contributor

Part of #8962

Description

This is part of UI support for displaying the product bundle hierarchy (parent/child relationship between the product bundle and its bundled products) in order details. We use AggregateOrderItem to combine order items and refunded items in order details. This PR adds the parent property to AggregateOrderItem so we can show the parent/child relationship in the UI.

We will use these changes to adjust the product list UI in order details in an upcoming PR.

Changes

  • Updates AggregateOrderItem to include parent.
  • Updates AggregateDataHelper to set the parent property when combining refunded products and order items. For refunded products, we look for the matching order item and get the parent from there.

Testing instructions

Confirm unit tests pass. We're not yet using this new property anywhere in the app.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@rachelmcr rachelmcr added category: woo extensions Related to WC extensions or plugins. feature: woo express support Related to Woo Express support labels May 19, 2023
@rachelmcr rachelmcr added this to the 13.7 milestone May 19, 2023
@rachelmcr rachelmcr requested review from Ecarrion and ThomazFB May 19, 2023 16:18
@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr9777-b9a0a92 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Base automatically changed from issue/8962-product-bundle-yosemite to trunk May 19, 2023 16:54
@spencertransier spencertransier modified the milestones: 13.7, 13.8 May 19, 2023
@ThomazFB ThomazFB self-assigned this May 20, 2023
Copy link
Contributor

@ThomazFB ThomazFB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rachelmcr rachelmcr merged commit 30c6d1c into trunk May 20, 2023
@rachelmcr rachelmcr deleted the issue/8962-product-bundle-aggregateorderitem branch May 20, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: woo extensions Related to WC extensions or plugins. feature: woo express support Related to Woo Express support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants