Skip to content

Conversation

@jaclync
Copy link
Contributor

@jaclync jaclync commented May 22, 2023

Closes: #9788

Why

Right now the share product CTA is buried inside the ellipsis menu. We can show it beside the ellipsis menu in the product form, and then hide it when there is more than one button like when the Save/Update CTA is shown after the merchant makes some changes.

How

I decided to show the share CTA on the leading edge of the existing CTA in the navigation bar, because the more/ellipsis menu can stay the same while the share CTA changes to Save/Update CTA after some unsaved changes.

The share CTA is added to ProductFormViewModel.actionButtons when there is up to 1 existing action and the product can be shared. In ProductFormViewController, the share CTA is then shown in the navigation bar that calls the same share function as from the more menu. A new event property source:product_form|more_menu was added to product_detail_share_button_tapped to see which source is the most effective.

Testing instructions

  • Log in if needed
  • Go to the products tab
  • Tap on the + button in the navigation bar to create a product --> in the product form, there should not be a share CTA
  • Tap Publish to publish the product --> after the product is saved remotely, a share CTA should be shown
  • Tap on the share CTA --> product_detail_share_button_tapped event should be tracked with source: product_form and a share sheet should be shown
  • Go back to the products tab
  • Tap on a product --> a share CTA should be shown
  • Tap on the more menu > Share --> product_detail_share_button_tapped event should be tracked with source: more_menu and a share sheet should be shown

Screenshots

Share CTA shown Share CTA hidden when more than 1 action is shown
Simulator Screen Shot - iPhone 14 - 2023-05-22 at 14 45 14 Simulator Screen Shot - iPhone 14 - 2023-05-22 at 14 45 25

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jaclync jaclync added the type: task An internally driven task. label May 22, 2023
@jaclync jaclync added this to the 13.8 milestone May 22, 2023
@jaclync jaclync marked this pull request as ready for review May 22, 2023 07:36
@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr9789-77ed9a3 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@itsmeichigo itsmeichigo self-assigned this May 22, 2023
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show the share CTA in product form

4 participants