Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

Part of #9788

Description

Previously, we were showing the share sheet from view controller view as the source view. On iPad, when the source view is too large, there is not enough space for the popover to be displayed. Hence when testing the share feature on iPad, the share sheet is not displayed when tapping on the Share button of the product form.

This PR fixes the issue by setting the bar button items in the product form as the source view for the share popover.

Testing instructions

  • Build and run the app on an iPad.
  • Log in to a store and switch to Products tab.
  • Select a product on the list and tap the Share button or tap Share in the ellipsis button.
  • Notice that the share popover is displayed correctly.

Screenshots

IMG_7561D24CA042-1
IMG_8E2E317426B7-1


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added type: bug A confirmed bug. feature: product details Related to adding or editing products, including Product Settings. labels May 23, 2023
@itsmeichigo itsmeichigo added this to the 13.8 milestone May 23, 2023
@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr9797-7d41c7f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@selanthiraiyan selanthiraiyan self-assigned this May 23, 2023
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@itsmeichigo itsmeichigo merged commit dd180b4 into trunk May 23, 2023
@itsmeichigo itsmeichigo deleted the feat/9788-fix-share-source branch May 23, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: product details Related to adding or editing products, including Product Settings. type: bug A confirmed bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants