Skip to content

Increase screen brightness when showing the QR code #9807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2023
Merged

Increase screen brightness when showing the QR code #9807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a612659
Increase screen brightness when showing the QR code
toupper May 24, 2023
39be451
Better naming
toupper May 24, 2023
4ab7c2f
Add Release note
toupper May 24, 2023
8cfa1c3
Add comment
toupper May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
- [*] Orders: Fixes a bug where the Orders list would not load if an order had a non-integer gift card amount applied to the order (with the Gift Cards extension). [https://github.com/woocommerce/woocommerce-ios/pull/9795]

- [*] My Store: A new button to share the current store is added on the top right of the screen. [https://github.com/woocommerce/woocommerce-ios/pull/9796]
- [*] Mobile Payments: The screen brightness is increased when showing the Scan to Pay view so the QR code can be scanned more easily [https://github.com/woocommerce/woocommerce-ios/pull/9807]

13.7
-----
Expand Down
9 changes: 9 additions & 0 deletions WooCommerce/Classes/ViewRelated/Orders/ScanToPay/ScanToPayView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ import SwiftUI
struct ScanToPayView: View {
let viewModel: ScanToPayViewModel
let onSuccess: (() -> Void)
/// We keep this value to reset the screen brightness after increasing it for better QR readability. Only works on phsycal device.
///
let screenBrightnessAtViewCreation = UIScreen.main.brightness

@Environment(\.dismiss) var dismiss

Expand Down Expand Up @@ -43,6 +46,12 @@ struct ScanToPayView: View {
.padding(Layout.scanToPayBoxOutterPadding)
.frame(maxWidth: .infinity, alignment: .center)
}
.onAppear {
UIScreen.main.brightness = 1.0
}
.onDisappear {
UIScreen.main.brightness = screenBrightnessAtViewCreation
}
}

private struct DoneButton: View {
Expand Down