Skip to content

Enable performance monitoring in production #9809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Enable performance monitoring in production #9809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80d900a
Sample 1% of transactions for performance monitoring
rachelmcr May 24, 2023
a3d8827
Enable performance monitoring in production
rachelmcr May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Experiments/Experiments/DefaultFeatureFlagService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
.performanceMonitoringNetworking,
.performanceMonitoringViewController,
.performanceMonitoringUserInteraction:
// Disabled by default to avoid costs spikes, unless in internal testing builds.
return buildConfig == .alpha
// Disabled for development builds.
return buildConfig == .alpha || buildConfig == .appStore
case .tapToPayOnIPhone:
// It is not possible to get the TTPoI entitlement for an enterprise certificate,
// so we should not enable this for alpha builds.
Expand Down
2 changes: 1 addition & 1 deletion WooCommerce/Classes/Tools/Logging/WooCrashLoggingStack.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ class WCCrashLoggingDataProvider: CrashLoggingDataProvider {
return .enabled(
.init(
// FIXME: Is there a way to control this via feature flags?
Copy link
Contributor

@wzieba wzieba May 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About usage of feature flags - on WCAndroid we recently disabled this feature as we were relying on Firebase Remote Config for that.

But for the future, I think it might be valuable to set performance sampling to use our in-house feature flag system (when it'll be integrated).

sampler: { 0.1 },
sampler: { 0.01 },
trackCoreData: featureFlagService.isFeatureFlagEnabled(.performanceMonitoringCoreData),
trackFileIO: featureFlagService.isFeatureFlagEnabled(.performanceMonitoringFileIO),
trackNetwork: featureFlagService.isFeatureFlagEnabled(.performanceMonitoringNetworking),
Expand Down