[Privacy Choices] Prevent banner from being dismissed #9815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
Ecarrion
force-pushed
the
issue/9811-prevent-banner-from-dismiss
branch
from
5981b84 to
8e86c53
Compare
Collaborator
You can test the changes from this Pull Request by:
|
rachelmcr
approved these changes
May 25, 2023
Contributor
rachelmcr
left a comment
rachelmcr
left a comment
There was a problem hiding this comment.
👍 This works.
Just noting that using a bottom sheet without being able to dismiss it makes it a little awkward if you try to swipe it away, since it can be mostly hidden:
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-05-25.at.14.02.09.mp4
Merging now so we can proceed with testing (discussion: p1685017504654089/1684966811.885719-slack-C02KUCFCSFP).
Contributor
Author
Yes, still it doesn't allow you to continue without selecting something but hopefully, this will be fixed once wordpress-mobile/WordPressUI-iOS#126 is merged and deployed 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9811
Why
This PR makes sure the privacy banner is not dismissable via a tap or a drag gesture.
The current bottom sheet implementation does not allow for that, This PR adds not ideal temporary solution while we update
BottomSheetViewControllerto allow for this behavior natively.Demo
Demo.mov
Testing Steps
RELEASE-NOTES.txtif necessary.