Skip to content

Fix hidden settings menu on iPad #9822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2023
Merged

Fix hidden settings menu on iPad #9822

merged 1 commit into from
May 25, 2023

Conversation

@Ecarrion
Copy link
Contributor

@Ecarrion Ecarrion commented May 25, 2023

Why

During the review of #9816 it was uncovered that the hidden settings menu crashed on iPad due to the lack of a a source view. This PR fixes that.

Screenshots

iPad Iphone
Screenshot 2023-05-25 at 8 52 46 AM Screenshot 2023-05-25 at 8 54 11 AM

Testing steps

  • Launch the app on an iPad
  • Navigate to the settings menu
  • Tap rapidly 4 times the heart icon at the bottom of the screen.
  • See the settings menu appear.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Ecarrion Ecarrion added the type: crash The worst kind of bug. label May 25, 2023
@Ecarrion Ecarrion added this to the 13.8 milestone May 25, 2023
@Ecarrion Ecarrion requested review from rachelmcr and wzieba May 25, 2023 14:00
@peril-woocommerce
Copy link

peril-woocommerce bot commented May 25, 2023

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@rachelmcr rachelmcr self-assigned this May 25, 2023
rachelmcr
rachelmcr approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. Looks great!

@Ecarrion Ecarrion enabled auto-merge May 25, 2023 15:08
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 25, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr9822-98ac3bd on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@Ecarrion Ecarrion merged commit 1032812 into trunk May 25, 2023
@Ecarrion Ecarrion deleted the fix/crash-menu-ipad branch May 25, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wzieba wzieba Awaiting requested review from wzieba

1 more reviewer

@rachelmcr rachelmcr rachelmcr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rachelmcr rachelmcr

Labels

type: crash The worst kind of bug.

Projects

None yet

Milestone

13.8

Development

Successfully merging this pull request may close these issues.

4 participants

@Ecarrion @wpmobilebot @rachelmcr