Make privacy banner not dismissable via WordPress UI tooling

[mokagio]

Description

Removes the workaround that was required while waiting for the changes in wordpress-mobile/WordPressUI-iOS#126 to be published

Testing instructions

I tested this by forcing the app to present the banner and by both tapping out of it and trying to drag it (in the Simulator) to verify it staid on screen. I'm not familiar with how the component should behave, and we don't have a demo for it in WordPress-UI, so I might have missed something.

I recorded myself during the process, but QuickTime crashed when I tried to crop the video...

For reference, here's the diff I used to force the display:

Diff

--- a/WooCommerce/Classes/ViewRelated/Dashboard/Settings/Privacy/PrivacyBannerPresenter.swift
+++ b/WooCommerce/Classes/ViewRelated/Dashboard/Settings/Privacy/PrivacyBannerPresenter.swift
@@ -27,16 +27,16 @@ final class PrivacyBannerPresenter {
         guard isUITesting == false else {
             return
         }
+
+//        guard ServiceLocator.featureFlagService.isFeatureFlagEnabled(.privacyChoices) else {
+//            return
+//        }
 
-        guard ServiceLocator.featureFlagService.isFeatureFlagEnabled(.privacyChoices) else {
-            return
-        }
-
-        let useCase = PrivacyBannerPresentationUseCase(defaults: defaults)
+//        let useCase = PrivacyBannerPresentationUseCase(defaults: defaults)
         Task {
-            if await useCase.shouldShowPrivacyBanner() {
+//            if await useCase.shouldShowPrivacyBanner() {
                 await presentPrivacyBanner(from: viewController)
-            }
+//            }
         }
     }
 

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

You can test the changes from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr9830-88ed395 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[Ecarrion]

I think we will also need let allowsUserTransition = false to prevent all gestures from dismissing the app.

[Q]: What problem do you see in making these computed vars? I think it may be easier for future maintainers to find all of these properties under the same protocol extension, what do you think? 😅

[mokagio]

Discoverability is a legit issue 🤔

What problem do you see in making these computed vars?

These values don't change, it seems inefficient to compute them at runtime when they could be set once.

Having said that, if it helps with discoverability, I'm happy to move them in the extension.

[mokagio]

Addressed in 5fc8207

[peril-woocommerce]

	Warnings
⚠️	This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

[Ecarrion]

Looks and tests great!
Thanks @mokagio for tackling this change!