[Reliability] Add failsafe decoding when String is received for stock_quantity #9850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9840
Description
This PR increases the app's resilience when the app receives a
Stringinstead of an expected value type for thestockQuantityonProductorProductVariation. (This is a known decoding error that users have experienced.)Core sends the stock quantity as an
Intornull, and we already convert that to an optionalDecimalto handle plugins that allow decimal quantities. This PR adds failsafe decoding fromStringtoDecimal, too.Testing instructions
We don't know the exact plugins that can cause this behavior, but you can test using a tool like Charles Proxy or Proxyman to intercept and modify the response:
/wc/v3/productsendpoint.stock_quantityfield returns a string representing a number or null value (e.g."stock_quantity": "1"or"stock_quantity": "").You can repeat the same steps with the variations list for a variable product, modifying the same fields in the response for a variation.
RELEASE-NOTES.txtif necessary.