Fix wrong check for site plan sync #9900
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up with an internal discussion: p1686154005250689/1686153929.996589-slack-C03L1NF1EA3
Description
@joshheald found that I made a mistake in the check for plan site sync as the logic check for skipping the site plan sync should check for WPCom login instead of the other way around. This error was from #8638 when I switch the logic from using siteID to using
isAuthenticatedWithoutWPCom.Testing instructions
It's not straightforward to test
DefaultStoresManagerfor this fix, and the site sync doesn't work properly after creating a free trial site so it's tricky to test this issue. I'd suggest putting a breakpoint inside theifblock to make sure that it's triggered only for when you log in with WPCom.Screenshots
N/A
RELEASE-NOTES.txtif necessary.