APMs automatically enabled when selecting "No, ..." during onboarding (4467) #3362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinamiko
requested changes
May 19, 2025
| @@ -165,7 +165,7 @@ public function reset_all_settings() : void { | |||
| */ | |||
| public function set_defaults_for_new_merchant( ConfigurationFlagsDTO $flags ) : void { | |||
| if ( $this->onboarding_profile->is_setup_done() ) { | |||
| return; | |||
| //return; | |||
There was a problem hiding this comment.
Check and fix this commented line.
There was a problem hiding this comment.
Forgot that sorry, fixed
…bled-when-selecting-no-during-onboarding
Dinamiko
approved these changes
May 19, 2025
…electing-no-during-onboarding # Conflicts: # modules/ppcp-settings/src/Service/SettingsDataManager.php
…electing-no-during-onboarding
Dinamiko
deleted the
PCP-4467-ap-ms-automatically-enabled-when-selecting-no-during-onboarding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the behaviour where APM's were enabled even if we selected "No" during onboarding.
The toggle $is_enabled now is conditioned to the flag "use_card_payments"