Skip to content

fifo test cleanup changed value #6031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
6543 merged 1 commit into from
Jan 28, 2026
Merged

fifo test cleanup changed value #6031

6543 merged 1 commit into from
Jan 28, 2026
+3 −0

Conversation

@6543
Copy link
Member

@6543 6543 commented Jan 28, 2026 •
edited
Loading

i hope to not see https://ci.woodpecker-ci.org/repos/3780/pipeline/31058/32 errors again with this

--- FAIL: TestFifoLeaseManagement (1.99s)
    --- FAIL: TestFifoLeaseManagement/wait_operations (0.96s)
        fifo_test.go:693: 
            	Error Trace:	/woodpecker/src/github.com/woodpecker-ci/woodpecker/server/queue/fifo_test.go:693
            	Error:      	Received unexpected error:
            	            	queue: task expired
            	Test:       	TestFifoLeaseManagement/wait_operations

regression of #6017 in test

@6543 6543 added bug Something isn't working tests related to tests or other things CI check before merge skip-changelog regression fix a bug that was not released yet labels Jan 28, 2026
@6543
Copy link
Member Author

6543 commented Jan 28, 2026

before we merge I'll rerun this few times while other workflows also run to see if we catched it :)

@codecov

This comment was marked as off-topic.

Sign in to view
@6543 6543 merged commit 6a76851 into woodpecker-ci:main Jan 28, 2026
9 checks passed
@6543 6543 deleted the harden-queue-test branch January 28, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xoxys xoxys xoxys approved these changes

Assignees

No one assigned

Labels

bug Something isn't working regression fix a bug that was not released yet skip-changelog tests related to tests or other things CI check before merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@6543 @xoxys