[pull] master from project-chip:master#700
Merged
Merged
Conversation
github-actions
Bot
added
documentation
Bumps [rojopolis/spellcheck-github-actions](https://github.com/rojopolis/spellcheck-github-actions) from 0.53.0 to 0.54.0. - [Release notes](https://github.com/rojopolis/spellcheck-github-actions/releases) - [Changelog](https://github.com/rojopolis/spellcheck-github-actions/blob/master/CHANGELOG.md) - [Commits](rojopolis/spellcheck-github-actions@0.53.0...0.54.0) --- updated-dependencies: - dependency-name: rojopolis/spellcheck-github-actions dependency-version: 0.54.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [third_party/imgui/repo](https://github.com/ocornut/imgui) from `823ccc2` to `86daa89`. - [Release notes](https://github.com/ocornut/imgui/releases) - [Commits](ocornut/imgui@823ccc2...86daa89) --- updated-dependencies: - dependency-name: third_party/imgui/repo dependency-version: 86daa8930e3b8ca9e75fac7307a1181e740c064a dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Decouple ICD Management cluster to be code driven. * Add cluster to decoupled list. * Add codegen integration * Add unit tests * Zap regen * Restyler * Addressed review comments. * Fix CI * Refactor the cluster implementation. * Reorder member varible for memory holes, validated buffer size before storing to userActiveModeTriggerInstruction * Rebase and zap regen * Rebase * Zap regen * Address copilot review
This commit explicitly cast the interface number to fix the conversion
warning:
```bash
error: conversion from ‘long unsigned int’ to ‘chip::Inet::InterfaceId::PlatformType’ {aka ‘unsigned int’} may change value [-Werror=conversion]
```
* Harmonize minimum required Python version to 3.11 Signed-off-by: Maciej Grela <m.grela@samsung.com> * Update pyproject.toml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Maciej Grela <m.grela@samsung.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Bump third_party/pigweed/repo from `abf1641` to `c21be8f` Bumps [third_party/pigweed/repo](https://github.com/google/pigweed) from `abf1641` to `c21be8f`. - [Commits](pigweed-project/pigweed@abf1641...c21be8f) --- updated-dependencies: - dependency-name: third_party/pigweed/repo dependency-version: c21be8ff8df5ffe7433b1e50a9023311413afd09 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * ZAP regen (due to restyle changes) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrei Litvin <andy314@gmail.com>
The Run() method in DCLCommandBase contained a 'return' statement that was unreachable because another 'return' preceded it. This commit removes the dead code to improve code clarity and maintainability.
* Batch #4 nodiscard errors: non-clusters app code * Fix clang
* Batch #2 nodiscard errors: example apps A-F * Fix clang tidy
Allow selecting extra gatt db header without depending on other config options. Allow deriving the base lock app AppTask and DeviceCallbacks classes. Signed-off-by: Marius Preda <marius.preda@nxp.com>
* Remove AttributeList from Device Layer It was only used in a single place and probably didn't belong in the device layer in the first place. Use a Span instead for DeviceInforProvider::SetUserLabelList. Also simplify DeviceInforProvider::ClearUserLabelList(). * Add missing const to Span type * Move max size constants into the header and add more tests * Allow the global DeviceInfoProvider to be reset to null This is primarily useful for testing. Also remove the comment stating that callers should assume the provider is not null; it starts out as null, and the cluster code interacting with it already handles null gracefully. --------- Co-authored-by: Andrei Litvin <andy314@gmail.com>
* Initial draft of all devices example app * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Address some review comments * Address more review comments * Restyled by whitespace * Restyled by clang-format * Restyled by gn * More review comments * Review comments for BUILD.gn configs * Restyled by clang-format * Restyled by gn * Add TODOs based on review comments * Restyled by whitespace * Restyled by clang-format * Update wifi diagnostics optional atteribute set usage * Remove SemanticTags function from Device * Restyled by clang-format * Make device endpoint a command line argument * Cleanup includes and remove old args.gni * Address comments, make command line args seperate from main * Restyled by whitespace * Restyled by clang-format * Restyled by gn * separation of base device with single endpoint device * Add comments, fix unregister calls, cleanup of member variables * Remove unique pointer for timer * Restyled by whitespace * Restyled by clang-format * update comment * Restyled by whitespace * Restructure device interfaces * Add all devices app build and basic composition test to CI * Restyled by clang-format * Remove build variants for CI, not currently supported * Fix path for all devices app in CI * Update device info provider used * Update comments * Restyled by whitespace * Restyled by clang-format * Add new device info provider * Restyled by whitespace * Restyled by clang-format * Update examples/providers/AllDevicesExampleDeviceInfoProviderImpl.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update examples/all-devices-app/all-devices-common/devices/boolean-state-sensor/BooleanStateSensorDevice.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update examples/all-devices-app/all-devices-common/devices/interface/DeviceInterface.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update examples/all-devices-app/all-devices-common/devices/interface/SingleEndpointDevice.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix build * Init on network commissioning * Remove unnecessary build gni imports * Restyled by whitespace * Restyled by clang-format * Restyled by gn * zcl updates * Revert "zcl updates" This reverts commit 70760c5. * Update dependencies and defines * Update with timer delegate changes * Restyled by clang-format * fix build file --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Andrei Litvin <andy314@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Clean up and make use of ValidateGlobalAttributes once. * Restyle * Fix an include path. * Use SuccessOrDie macro. * Move the implementation to a cpp file, to avoid douple definition errors (e.g. in NRF). * Remove extra impl. * Update src/app/clusters/testing/ValidateGlobalAttributes.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/app/clusters/testing/ValidateGlobalAttributes.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * s/Paramter:/Parameters:/ * Use reference in one more for loop. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
For Trusty OS backed P256KeyPair, p256_Handler points to the contexts of the keypair generation, so it not be used as a global variable. This fix store p256_Handler in P256Keypair:mKeypair. Signed-off-by: Maximus <maximus.sun@nxp.com>
of always calling check in complete.
* Add error logging to `Is*ListEqualTo` functions * Add `GetNextGeneratedEvent` to class `Cluster` and make `Invoke` fully deduce template parameters This was removed from PR #41603 by mistake * Restyled by clang-format * Update `ClusterTester::Invoke` usage in `TestGroupcastCluster.cpp` * Update comment for `ClusterTester::Invoke` * Add license notice and `#pragma once` in some files. * Use initializer list for `IsGeneratedCommandsListEqualTo` --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Updated the steps of TC-CC-10-1 store scene tests * Apply suggestions from code review Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Updated test steps * Reverting tolerance changes * Update src/python_testing/TC_CC_10_1.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/python_testing/TC_CC_10_1.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Batch #5 nodiscard errors: clusters app code * Fix CI & missed cleanup * Missed cleanup * Clang tidy
* Adding the ability to disable this * Update src/darwin/Framework/CHIP/MTRDevice_Internal.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/darwin/Framework/CHIP/MTRDevice_Concrete.mm Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Batch #9 nodiscard errors: inet, messaging, system * Inadvertent change * Update src/messaging/ExchangeMgr.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
…#41928) * remove the coupling of InteractionModelEngine in DefaultTimerDelegate * update dependency * Restyled by clang-format * add missing header * add timer-delegate-default to app dependency * relocate DefaultTimerDelegate to platform * cleanup * Restyled by clang-format * update based on master change --------- Co-authored-by: Restyled.io <commits@restyled.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )