[pull] master from project-chip:master#739
Merged
Merged
Conversation
github-actions
Bot
added
workflows
github
esp32
scripts
test driver
platform
linux
documentation
github-actions
Bot
added
transport
system
lib
integrations
crypto
support
docker
telink
labels
* [Fix] Fix webOS's bluetooth overflow problem detailed: Prevent overflow lisk * [Fix] Fix webOS's bluetooth overflow problem detailed: Prevent overflow lisk * [Fix] Fix webOS's bluetooth overflow problem detailed: Prevent overflow lisk
…wn announcement reasons (#71757) * Handle unknown announcement reasons with a constraint error. * Minor formatting fixes. * Restyled by clang-format * Change constraint checks to use VerifyOrReturnError. * Assert that an event was generated in the tests before checking its details. * Add lint silencers when accessing optionals that are guarded by test asserts. * Remove extra semicolon. * Add the extra test macros to assist with the Darwin "unchecked optional" linter check. * Missed an ASSERT_TRUE on an optional in a test. --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Added a 1 sec delay between the Recall Scenes and Attribute Read * Restyled by isort * Polling mechanism to replace the 1s wait * Added a generic method that can be called for any cluster testing scenes * Addressing Linting errors * Updated to match suggestions * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…dor-id, --product-id --interface-id" and remove dependency on global LinuxDeviceOptions (#71735) * Refactor all-devices-app to remove reliance on global options and add KVS support * Fix compilation errors in main.cpp after AppOptions refactor * Add support for --vendor-id and --product-id options in all-devices-app * Address review comments: make GetConfig() const and restore default device fallback * Rename deviceConfigs to deviceTypeEntries for consistency * Update DeviceTypeParser: rename member variable and fix doc comment * Add validation for discriminator option * Move AppDeviceInstanceInfoProvider to a separate header file * Separate AppDeviceInstanceInfoProvider into .h and .cpp files * Apply restyling and style fixes * Move provider files to all-devices-common (rename only) * Implement full DeviceInfoProviderImpl and update build files * Apply restyling fixes * Rename DeviceInstanceInfoProviderImpl to OverrideDeviceInstanceInfoProvider and add safe fallbacks * Support setting port dynamically via --port option * Support --interface-id option in all-devices-app * Split providers into separate source sets and fix includes * Use short include paths for files in all-devices-common * Move providers to a separate sub-directory in all-devices-common * Remove singleton from DeviceInfoProviderImpl and move instance to local static in Initialize * Rename DeviceInfoProviderImpl to TestDeviceInfoProviderImpl * Implement Friend Pattern for iterators in TestDeviceInfoProviderImpl * Use VerifyOrReturnError pattern in OverrideDeviceInstanceInfoProvider.cpp * Fully switch to std::optional in AppOptions and OverrideDeviceInstanceInfoProvider * Use value_or for port in main.cpp and always log the port used * Rename TestDeviceInfoProviderImpl back to AllDevicesExampleDeviceInfoProviderImpl * Rename OverrideDeviceInstanceInfoProvider to AllDevicesExampleDeviceInstanceInfoProviderImpl and apply restyling * Use value_or for discriminator in main.cpp
* Make all pairingsession schedulework async, since that is safer * Add a unit test * Restyle and log text fix * More comments * Do not nest expects * Revert previous changes, move to a destructor tracking * Slight update in comments and code * Undo unrelated changes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Unit test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Also update PASE * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Wording update. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Remove new nlassert error * Just flip order * Also guard against session expire while we are async notifying * Add some unit tests * Fix tests * Correct call directly to delegate * Update src/protocols/secure_channel/CASESession.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Save the system layer rather than trying to use devicelayer, to support device layer none * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* [nrfconnect] Add support for non-PM factory data generation Adds support for factory data generation using devicetree data from the primary sysbuild image, if partition manager is not enabled for a build * [nrfconnect] Overwrite PSA Session Keystore to meet KMU requirements We need to overwrite the PersistICDKey method of the PSASessionKeystore because we must export the volatile key first and then import it again into the KMU slot instead of copying it. Currently copying keys from the RAM location to the KMU slot is not supported. This is workaround that should not be upstreamed. It can be removed once the other solution is found. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * [nrfconnect] Align OpenThread Kconfigs with Zephyr changes Replace `NET_L2_OPENTHREAD` with `OPENTHREAD` as OpenThread Kconfigs were moved from L2 to OpenThread module. Keep `NET_L2_OPENTHREAD` if there is dependency to networking. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [nrfconnect] Enabled OT version without L2 by default Enabled OT configuration without L2 by default for nrfconnect platform. Additionally moved some L2 related Kconfigs implied by CHIP to a separate Kconfig. Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no> * [nrfconnect] Switch to picolib Switched from newlibc to picolibc in Nordic platform. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * [nrfconnect] Remove dependency to DK in Matter configuration In Matter configuration there must not be anything related to DK. All DK-related Kconfigs must be defined in the application. The CHIP_SPI_NOR and CHIP_QSPI_NOR configs are no longer needed and we can use NORDIC_QSPI_NOR and SPI_NOR instead. According to the Zephyr guidelines, do not write "Enable" for boolean prompts. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * [nrfconnect] Add Kconfig to enable detailed logging of Matter messages This commit adds a new Kconfig which enables enhanced verbosity for logging content of Matter messages. Signed-off-by: Łukasz Duda <lukasz.duda@nordicsemi.no> * [nrfconnect] Increased BT stack size for NUS use case In case of using NUS with 54L family the BT RX stack size has to be increased. Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no> * [nrfconnect] Increase HEAP pool size for Matter over Thread Currently, commissioning to real Matter ecosystems requires more than 8 kB of HEAP. We need to increase the default value to meet this requirement. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * [nrfconnect] Increase Matter stack size after update to Matter 1.5 Some samples require more stack after updating Matter to 1.5. Increase the default value by 2kB. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * [nrfconnect] Increase ICD observer pool size The ICDMnager observer for the DNS-SD server was silently not registered which causes the OnICDModeChange function to be called on change from SIT to LIT. The root cause is that in Matter 1.5, there is an additional observer, and we have a too small pool size to fit the 3rd one for the DNS-SD Server. Increase the CHIP_CONFIG_ICD_OBSERVERS_POOL_SIZE to 3 for the Nordic platform. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * [nrfconnect] Switch from Fixed passkey to app passkey According to BT Spec we cannot use fixed passkey logic anymore and we must switch to app passkey. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * [nrfconnect] Allow inheriting DiagnosticDataProviderImplNrf The default constructor of DiagnosticDataProviderImplNrf must be protected instead of private to allow inheriting it in the user's implementation. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * [nrfconnect] Fix building with custom factory data impl Include the implementation of the GenericDeviceInstanceInfoProvider class in the nRFConnect's DeviceInstanceInfoProviderImpl.cpp file in case of using a custom factory data provider. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * [nrfconnect] Expose FactoryDataBase outside nrf implementation - Moved FactoryDataProviderBase outside the FactoryDataProvider.h to not build the FactoryDataProvider.h while a custom implementation is used. - Added Kconfig choice to select the factory data backend to easily switch between NRFCONNECT and CUSTOM ones. The new approach is backward compatible, and by default it is set to CHIP_FACTORY_DATA_NRFCONNECT_BACKEND. To use custom backend: Set CONFIG_CHIP_FACTORY_DATA_CUSTOM_BACKEND=y and SB_CONFIG_MATTER_FACTORY_DATA_GENERATE=n Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * [nrfconnect] Do not define _POSIX_C_SOURCE in CMakeLists This define now comes from Zephyr, and we should use it instead of declaring it in the CMakeLists.txt. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * [nrfconnect] Update nRF Soc Kconfigs Updates Kconfigs for SoC selection due to a Kconfig change * [nrfconnect] Use POSIX_AEP_CHOICE_NONE if CHIP_LIB_SHELL Currently the CHIPArgParser uses the standard getopt() API, so we cannot use the Zephyr's sys_getopt() API which is enabled by POSIX_AEP_CHOICE_ZEPHYR. The POSIX_AEP_CHOICE_ZEPHYR is set now by default, so we need to switch to POSIX_AEP_CHOICE_NONE if we want to use CHIP_LIB_SHELL. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * [nrfconnect] Remove redundant ETH_NATIVE_POSIX config nRFConnect test driver does not need CONFIG_ETH_NATIVE_POSIX, and this config was deprecated in Zephyr in favor of CONFIG_ETH_NATIVE_TAP. To meet Zephyr's requirements remove it from the configuration. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * [nrfconnect] Add Kconfig for CHIPoBLE single connection mode Add `CONFIG_CHIP_CHIPOBLE_SINGLE_CONNECTION` Kconfig to control CHIPoBLE single conection mode. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [nrfconnect] Add Kconfig for nRF QSPI NOR power management Add `CONFIG_CHIP_QSPI_NOR_POWER_MANAGEMENT_SUPPORT` Kconfig that guards power state handling for nRF QSPI NOR external flash. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * [nrfconnect] Optimize OTA time Reduced OTA time by 15-20% Signed-off-by: Adam Maciuga <adam.maciuga@nordicsemi.no> * [nrfconnect] Enable PSA for Wi-Fi Now that Wi-Fi supports PSA for personal security, enable PSA in Matter too. * [nrfconnect] Add new Crypto backend for Matter over Wi-Fi Allow switching between PSA and MBedTLS. Enable all PSA configs required by Matter. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * [nrfconnect] Fix missing returns error in WiFi Mgr Fixed not checked return from several functions in WiFi Manager. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * [nrfconnect] Bump nrfconnect recomended version Update to nRFConnect 3.3.0 Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * [nrfconnect] Align nrfconnect platform to the new docker image Changed a script for preparing zephyr environment. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * Alignments or nrfconnect v3.3.0 Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * Addressed copilot review comments Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no> --------- Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no> Signed-off-by: Łukasz Duda <lukasz.duda@nordicsemi.no> Signed-off-by: Adam Maciuga <adam.maciuga@nordicsemi.no> Co-authored-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> Co-authored-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no> Co-authored-by: Łukasz Duda <lukasz.duda@nordicsemi.no> Co-authored-by: Adam Maciuga <adam.maciuga@nordicsemi.no>
…the manual yaml script as Python based Automation script is avaialble. (#71604) * Modify test steps for Groupcast commands Added step 0c to the test step label in TC-MOD-2.3. * Update TC_CC_10_1.py Added step 0c to Test step label in ColorControl cluster * Update TC_LVL_9_1.py Added the step0c to test step label in TC-LVL-9.1. * Update TC_OO_2_7.py Added step0c to the test step label in TC-OO-2.7. * Delete src/app/tests/suites/certification/Test_TC_DISHM_1_2.yaml Removing the TC-DISHM-1.2 yaml manual script as Python script is available * Restyled by autopep8 * Update TC_OO_2_7.py * Refactor membership attribute read and command sends * Refactor groupcast membership checks and commands * Improve readability of groupcast membership handling Refactor groupcast membership checks and command sends for better readability. * indent fix --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Clarify Naming Convention in Chef Example Stubs * refactor comment
* Add force transmit of log during Init phase * fix copilot comments
* Device composition tests: Add option to run tests from file This PR allows us to injest data dumps from previous runs, and run tests against them. This works for device basic composition tests, device conformance tests, and pics tests. * Restyled by isort * Actually add the file this time * Fix flake8 * Restyled by clang-format * Fix some post-merge problems * Update device drawing script * Revert "Update device drawing script" This reverts commit a075325. * Address review comments * Add from-file test method to CI * Restyled by isort * Fix up Json functions in ChipDeviceCtrl * whoopsie doodles - thanks mypy * Add topology parsing function to framework * Update drawing script to use parser * fix filename * remove stray import * how did this get SO messed up * Updates to graph file * render from within the graph script * Restyled by isort * Use TypeAlias because type is 3.12 * Fix bad merge * fix lib declaration * Restyled by ruff * add missing include * Update drawing script to new file layout * remove code that moved * move into test_testing * Remove changes that remain in ChipDeviceCtrl * Restyled by ruff * linter * typo --------- Co-authored-by: Restyled.io <commits@restyled.io>
* [ESP32] Factor out LEDWidget as a component There were a few copies of LEDWidget, I guess the source-app got copy-pasted. Refactored the LEDWidget into a component which can be added to these apps. Removed LEDWidget from: - all-clusters-minimal-app - all-clusters-app - lighting-app - lock-app and moved it to examples/platform/esp32/led_widget. This component support LED_TYPE_RMT, LED_TYPE_GPIO, and Virtual LEDs on M5Stack's display. * [ESP32] Update stale ColorControl comments to match new guard The compile guard changed from CONFIG_DEVICE_TYPE_ESP32_C3_DEVKITM to CONFIG_LED_TYPE_RMT but the comments still referenced C3-only. * [ESP32] Add ESP32DimmableLightDevice to all-devices-app Adds a hardware-backed dimmable light implementation for ESP32 that drives a real LED (GPIO/LEDC or RMT/WS2812) via the shared led_widget component. Overrides the default LoggingDimmableLightDevice in the DeviceFactory so that `devtype set dimmable-light` controls the on-board LED with on/off, brightness, and identify blink. * add screen framework to the list of requirements * restyle * remove the vled from led_widget and move it into screen framework * Restyled by clang-format * fix blink timing and identify handler in LEDWidget * address review from copilot --------- Co-authored-by: Restyled.io <commits@restyled.io>
…op (#71913) * Move processing to the chip thread for the bridge app * Fix locking * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…on enum. (#71874) * Use the updated name for the announcement reason enum. Also stop including the enum compatability header from the test. It's supposed to only be included by cluster-enums.h. * Add the extra header to assist the Darwin linter with the attribute tests.
* Stop ignoring CHIP_ERROR returns from some callsites * Integrate AI comments * clang-tidy fixes * change a VerifyOrDie to SuccessOrDie * revert src/crypto/PSAOperationalKeystore.cpp
…71863) * Start defining an implementation plan for all-devices-app * Phase 1 * Fix phase one: make m5stack compile * phase 2 * Split build separation * all-devices build ability with a single device * Remove the devel docs for now - work is done * Restyle * Sort and fix merge conflict * A bit more sane list keeping * Restyle * Fix all-devices targets * Better comments * Update all-devices to include the temperature sensor * Some comments and register consistency * Fix esp_example.sh with elf naming * Restyle * Update based on code review comments * Use default device in posix * Use default device in esp32 * Restyle * Fix typo * Some review updates * Fix esp32 compile * Posix: support --endpoint properly for different default device * Fix default * Code review comments * Code review comments * Restyle * Count elf files found, review comment * Print out all found elfs * Restore license * Updated based on review comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update after merge with master: conditional enable of dimmable light * Restore truncated license * More merge fixes --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…71823) * code-driven: cluster server implementation for pressure measurement Adds a code-driven PressureMeasurement cluster server with: - Mandatory attributes: MeasuredValue, MinMeasuredValue, MaxMeasuredValue - Optional attributes: Tolerance - EXT feature: ScaledValue, MinScaledValue, MaxScaledValue, ScaledTolerance, Scale - Config builder with WithTolerance(), WithScaledValue(), WithScaledTolerance() - CodegenIntegration for Ember compatibility - Chef pump example migrated to use new SetMeasuredValue API * code-driven: add unit tests for pressure measurement cluster Tests cover mandatory attributes, optional tolerance, constructor variants with negative values, range validation, measured value bounds checking, EXT feature (scaled value, tolerance, scale), and feature map with/without EXT. * zap-regen: update pressure measurement attributes to callback storage Regenerated from updated .zap files where MeasuredValue, FeatureMap, and ClusterRevision are now callback (External) storage instead of RAM, matching the code-driven cluster server pattern. * restyle * code-driven: add pressure-measurement-server to clusters BUILD.gn * code-driven: migrate ASR apps to pressure measurement API and improve test coverage - Migrate all-clusters-app/asr and platform/asr/shell to use PressureMeasurement::SetMeasuredValue() instead of the removed Attributes::MeasuredValue::Set() - Add test coverage for MinScaledValue/MaxScaledValue reads - Add test for SetScaledValue without EXT feature (expect CHIP_ERROR_UNSUPPORTED_CHIP_FEATURE) * restyle * address review comments --------- Co-authored-by: Andrei Litvin <andy314@gmail.com>
The NXP MCXW71 platform is no longer supported in Matter 1.6. Signed-off-by: Marian Chereji <marian.chereji@nxp.com>
* [PICS Generator] Use spec conformance evaluator for event PICS The event branch was checking the PICS template's `cond` attribute by literal string equality against the cluster PICS code or the feature PICS list. That worked for unconditional or single-feature events, but missed compound conditions like "ACL.S AND ACL.S.F00", leaving those events at support=false even when the device had the gating feature. Use the conformance evaluator TC_DeviceConformance already uses, fed by the device's actual feature map, attribute list, command list, and cluster revision. That covers AND, OR, NOT, parens, feature gates, and attribute gates. Verified on all-clusters-app: mandatory events now auto-marked across TIMESYNC, ACL, BINFO, DGGEN, OCC, BOOLCFG, BOOL, SWTCH and SMOKECO. Fixes #71905 * PICS-generator: fix EventList wording (deprecated, not provisional) Per review feedback from Rene: EventList (0xFFFA) is deprecated (conformance D) and the SDK no longer implements it (PR #35874). Calling it "provisional" is left over from 1.0/1.1 and is wrong today. - PICSGenerator.py: update the new event-PICS comment and the pre-existing global-attributes comment at line ~432 to say "deprecated, not implemented by the SDK". - README.md: rewrite the events bullet using Rene's suggested wording so users understand event PICS are marked purely from spec conformance and may not match the actual device. Comment-only and docs-only; no behavior change.
* [BDXTransfer] Initialize variables in a class. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…rence/use the data TLV (#71928) * double-check pointer dereference * Fix test: only check no crash * Rename apData to aData to remove pointer naming * Another name update * Update it a bit more careful: ensure we do not add extra checks * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Add some recursion limit * Reduce stack frame size * One more fix
…ist (#71895) * checkout_submodules.py: Support comma- and space-separated platform listscheckout_submodules.py: Support both comma- and space-separated platform lists The documentation (docs/guides/BUILDING.md) shows usage like: python3 scripts/checkout_submodules.py --shallow --platform platform1,platform2 However, argparse treats 'linux,esp32' as a single invalid choice, so comma-separated platform lists do not work. Only space-separated values were accepted. This change updates the script to accept both formats by splitting comma-separated entries, allowing: --platform linux esp32 and --platform linux,esp32 Signed-off-by: Martin Flaska <flegy@flegy.sk> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * checkout_submodules.py: addressing gemini review comments Move code from the helper functions to the main function. Signed-off-by: Martin Flaska <flegy@flegy.sk> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * checkout_submodules.py: addressing gemini review comments Signed-off-by: Martin Flaska <flegy@flegy.sk> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Martin Flaska <flegy@flegy.sk> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Add cleanup step to tests * Restyled by ruff * Restyled by autopep8 * Apply suggestions * Apply suggestions from code review Co-authored-by: Shubham Patil <shubham.patil@espressif.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Shubham Patil <shubham.patil@espressif.com>
Signed-off-by: Gatien Chapon <gatien.chapon@nxp.com>
…ecreation (#71470) * Flush event handler events to remove stale events. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Fix heap-use-after-free bug in PushAVClipRecorder::EnsureDirectoryExists The bug occurred when the method was called during object destruction, causing std::filesystem::remove_all() to trigger a callback that led back to EnsureDirectoryExists on the same object that was being destroyed. The fix ensures that the member variable mUploadFileBasePath is only updated after all filesystem operations succeed, preventing access to inconsistent state during object destruction. * Fix recorder initialization. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Restyled by clang-format * Fix TC failure in CI for begin event and handle crash. Signed-off-by: Raveendra Karu <r.karu@samsung.com> * Fix CI failure recieving 2 begin events for manual trigger * Restyled by clang-format * Fix CI build failure * Fix inactive case of motion trigger * Update pushav-transport Updated logic to initialize recorder in case of motion trigger while transport is inactive Co-Author: Tushant Yadav <t.yadav@samsung.com> * intermediate fix * test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Raveendra Karu <r.karu@samsung.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Amine Alami <43780877+Alami-Amine@users.noreply.github.com>
Problem statement: After recent NCS update to 3.3.0, the kernel versions were changed in headers, what lead to failures. The nRF platform often uses intermediate Zephyr versions like 4.3.99 (not 4.3.0 or 4.4.0). Workaround: For nrfconnect target included NCS version and used it in version checks.
* nfc-ethernet in python controller * fix restyle * fix restyle issue * fix restyle issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )