[pull] master from project-chip:master#742
Merged
Merged
Conversation
…tton (#71909) * Fixing the build for the boards without the button * adding the btn condition while overriding the API * reverting the addition * Adding the include file * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Refactor the btns --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…1738) * Add basic migration implementation from SafeAttributePersistence * Fixes for ResourceMonitoring instances * Fix error in Nullable type storage * Add unit tests * Restyled by whitespace * Restyled by clang-format * Try to fix compilation errors * Remove Migrate code from main cluster build * More compilation changes * More compilation changes * Add dependencies to cmaeke * Add changes to build and remove FD * Restyled by gn * Remove header --------- Co-authored-by: Restyled.io <commits@restyled.io>
* [NXP] fix random BLE adv issue due tasks execution timing/order Signed-off-by: Martin Girardot <martin.girardot@nxp.com> * Fix PR comments Signed-off-by: Martin Girardot <martin.girardot@nxp.com> * Fix PR comment Signed-off-by: Martin Girardot <martin.girardot@nxp.com> * [NXP] Fix PR comment for renaming Signed-off-by: Martin Girardot <martin.girardot@nxp.com> --------- Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
* [NXP] Add wifi scan CLI command and fix NXP wifi scan issue Signed-off-by: Martin Girardot <martin.girardot@nxp.com> * Restyled by whitespace * Restyled by clang-format * Fix PR comments Signed-off-by: Martin Girardot <martin.girardot@nxp.com> * Fix PR comments Signed-off-by: Martin Girardot <martin.girardot@nxp.com> * Restyled by whitespace * Fix PR comment Signed-off-by: Martin Girardot <martin.girardot@nxp.com> --------- Signed-off-by: Martin Girardot <martin.girardot@nxp.com> Co-authored-by: Restyled.io <commits@restyled.io>
* Restyle * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… chip-tool to test examples (#71904) * Add chip-tool-testing skill for AI agents * Update configuration cache description in skill * Address bot review comments in skill file * Add Reporting Results section to skill * Refine reporting section in skill to be more generic * Restyle SKILL.md to fix CI failures * Clarify KVS note in skill to address review comment * Apply user formatting edits and restyle fixes to SKILL.md * Address review comments on SKILL.md * Manually format SKILL.md with prettier v1.19.1
* Lighting App CRTP refactor * fix macros * Restyled by prettier-markdown * apply fixes * apply fixes * Restyled by clang-format * address comments * Restyled by whitespace * Restyled by clang-format * app refactor * Restyled by clang-format * fix issues * fix singleton * Use Impl in apptaskImpl and update macros * readme update * rework * comments * comments * Restyled by clang-format * lcd * Restyled by clang-format * comments * comments * Update examples/lighting-app/silabs/README.md Co-authored-by: Sergei Lissianoi <54454955+selissia@users.noreply.github.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Sergei Lissianoi <54454955+selissia@users.noreply.github.com>
…1961) * Add prettier for markdown to pre-commit and disable in restyler * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Fix path to the zap packages * Update zap to 2026.05.05 * Make python 3.14 work on bootstrap * zap regen * Restyle * Correct order of api maturity for event generation
github-actions
Bot
added
documentation
* Fix default script path in run_python_test.py Point to tests/scripts/ instead of test/test_scripts/ to match actual repository structure. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Revert accidental hardcoding of camera controller app * Restore MetadataReader import --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… Cluster (#71944) * File renames and code movement * Address gemini comments * Add alias for Delegate for backwards compatibility
Bumps [third_party/ot-br-posix/repo](https://github.com/openthread/ot-br-posix) from `717abf0` to `7c45251`. - [Release notes](https://github.com/openthread/ot-br-posix/releases) - [Commits](openthread/ot-br-posix@717abf0...7c45251) --- updated-dependencies: - dependency-name: third_party/ot-br-posix/repo dependency-version: 7c4525136cf31dbf50d7a846f865da827d3f1d4c dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* remove unwanted depencies * fix comments
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.3 to 4.35.4. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@e46ed2c...68bde55) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.35.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [third_party/pigweed/repo](https://github.com/google/pigweed) from `de5b668` to `86f3575`. - [Commits](pigweed-project/pigweed@de5b668...86f3575) --- updated-dependencies: - dependency-name: third_party/pigweed/repo dependency-version: 86f3575467c77dcc00dfa8a7f30c01b61b609e71 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Implement commissioning status checks and factory reset assertions in testing framework - Added `is_commissioned` and `get_commissioned_fabric_count` functions to check device commissioning status. - Introduced `require_factory_reset` and `skip_if_commissioned` decorators to enforce factory-fresh state for tests. - Updated `assert_factory_fresh` and `assert_is_commissioned` assertions for better validation of device state. - Refactored `TC_SC_7_1` test to utilize new commissioning helper for verifying factory reset status. These changes enhance the testing framework's ability to ensure devices are in the correct state before running tests. * Add PASE session establishment to commissioning status checks - Introduced `_establish_pase_session` function to handle PASE session establishment with various methods (on-network, BLE). - Updated `is_commissioned` and `get_commissioned_fabric_count` functions to accept optional PASE parameters for establishing a session if the device is not commissioned. * fix chipstack linter failure * fix minor mypy issue * Refactor commissioning status checks in decorators - Introduced a new internal helper function `_check_commissioning_status` to streamline the process of checking if a device is commissioned. - Updated `require_factory_reset` and `skip_if_commissioned` decorators to utilize the new helper function, improving code readability and reducing duplication. - Removed redundant imports of `is_commissioned` from the decorators and assertions in `matter_asserts.py` to enhance clarity and maintainability. * isort * revert the copilot suggestion * address review comments * Refactor: Use FindOrEstablishPASESession and rename _establish_pase_or_case_session * linter fixes * mypy fix * add commissioning integration tests to CI to check the timings * replace EstablishPASESession with FindOrEstablishPASESession * run commissioning status detection integration tests with environment loading * fix copilot suggestion * resolve port conflict and fix error message ordering * fix docstring and remove unreachable code * Update docstrings to include new error handling for DNS-SD and session establishment failures * Fix imports in integration test after merge * Address review comments: Rename assertions and clarify comments * Fixed minor docstring inconsistencies * Address review feedback: Remove mdns_discovery import guard and hardcode endpoint 0 * Restyled by isort * Address Copilot CI review: Remove standalone app args to avoid mDNS collisions * address reviewer comments * Address CI Checks Failing, Address copilot review comments * Restyled * Fix for CI error * Address CI Fail for edge cases * Further addresses ci fail towards new extract_commissioned_fabric_count function * Sync with draft PR 71448 for CI validation * Add missing files on BUILD * Address reviewer comments: Python path module refactor * Fix redundant exceptions in dns-sd, syntax errors in matter_asserts docstrings, and add matter_asserts to mypy validation * Address review comments: mDNS-based is_commissioned, remove PASE side-effects --------- Co-authored-by: Fran <franluntref@gmail.com> Co-authored-by: Franco Lionti <43421214+FrancoLionti@users.noreply.github.com>
* Don't shadow builtin Python symbols in scripts/** * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* fix zephyr light silabs * apply comments * fix comments * Apply comments * fix comments * fix comments * Apply comments
* Bugfix: Group iterator release. * Code review.
* Decouple mode base cluster part 1 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Restyled by gn * Address review comment * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
…tion attribute (#43477) * Add XML changes for new ImageRotation discrete angles attribute in Camera AVSM cluster. * Run zap regen tool for code-gen of the new attribute. * Re-run with latest alchemy * Add new attribute to the zcl files. * Re-run zap regen script. * Move new attribute to the end of the existing attributes.
* Use exit stack for init/deinit flow in process Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Properly propagate exception stacks from WrappedProcess Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Distinguish initialization and work exceptions by adding a note Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Remove redundant comments Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix Self import Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Capture exceptions that are not errors within the exit stack Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Improve documentation around process lifetime Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Ensure to close the socket Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Fix grammar Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Make thread a member of the XMLRPC server class Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Improve messaging on XMLRPC Server stop Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Fix typo Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> --------- Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Enforce minimum MTU in BLE connections BTP protocol in Matter provides for automatic MTU negotiations. Provide additional sanity checking on the receive side to allow the protocol to make forward progress. * Define `sMinFragmentSize` to represent minimum acceptable fragment size * Verify the communicated value is larger than the `sMinFragmentSize` * Added a new unit test EnforcesMinFragmentSize to verify that SetTxFragmentSize and SetRxFragmentSize correctly clamp values below sMinFragmentSize . * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update src/ble/BtpEngine.h Co-authored-by: Andrei Litvin <andy314@gmail.com> * Apply suggestion from @robszewczyk * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestion from @andy31415 * unit tests suggestions from copilot * Fix compile * fix typo * unsigned arithmetic * typo * add an explicit cast --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Andrei Litvin <andy314@gmail.com>
* [NXP] Fix coverity issue Signed-off-by: Martin Girardot <martin.girardot@nxp.com> * Fix PR comments Signed-off-by: Martin Girardot <martin.girardot@nxp.com> --------- Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
Signed-off-by: Zhibin (Ryan) Wen <wenzhibin@espressif.com>
* Groupcast: IANA address corrected. * Code review. * Initial python changes for testsing * Update python code with new IANA address * unit test updates * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Address review comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Removed unused code * Fix wording * update comment --------- Co-authored-by: Zaid Omer <zaidomer@google.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Remove nlassert dependency from core SDK code - Implement AssertBase.h a new header file with base assert-like verification functions and `abort` hook. This is now included by CodeUtils.h and used in places where ChipLog* functions cannot be used. It is also a replacement for VerificationMacrosNoLogging.h - Drop dependency on nlassert in src/lib/support and other places of the core SDK code. It is included now only when nlfaultinjection is pulled in - Add multiple missing includes for <cstdio> where applicable * nlEXPECT was missed in two places * Include sys/types.h for `ssize_t` definition * Restyled by clang-format * nxp: Add missing #include <cstdio> * Implement post-review changes - VerifyWithAction is now a single statement not a block - depend on chip_config_header - drop `base` keyword from target and include file names * Keep it simple by formatting all the macros with clang-tidy --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Add support for linux 32bit builds * Added necessary entries in targets.py and host.py to allow linux ARM builds. * Updated a few *.cpp files to use standard printing format to pass compilation. * Address review feedback related to formatting types * Fix unit test * Recreate targets file again... --------- Co-authored-by: Andrei Litvin <andy314@gmail.com> Co-authored-by: Andrei Litvin <andreilitvin@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )