fix: Await configuration before initializing network logging #243
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without awaiting the GBKit configuration global, a race condition often led to disabled fetch interception, even though the `enableNetworkLogging` configuration was enabled.
8 tasks
dcalhoun
deleted the
fix/await-configuration-before-initializing-network-logging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Mitigate a race condition unexpectedly disabling network logging.
Why?
Without awaiting the
GBKitconfiguration global, a race condition often led to disabled fetch interception, even though theenableNetworkLoggingconfiguration was enabled.How?
Await the
GBKitconfiguration global before initializing thefetchinterceptor.Testing Instructions
Important
I was only ever to reproduce the race condition while using the WordPress-Android app while using a local production build (
make build). It was not reproducible in the GutenbergKit Demo app or while using a local development server (make dev-server).This requires:
gradle/libs.versions.tomlto this GutenbergKit branch's most recent commit.WordPress-Androidin Android Studio.Accessibility Testing Instructions
N/A, no user-facing changes.
Screenshots or screencast
gbk-network-logging.mov