-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Gutenberg] - React Native 0.69.4 Upgrade #17066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 34 commits
3be6f11
67db3c8
52acffc
650ad55
cc396b9
8d352e6
91efb5f
0aab584
e2c4645
5d16496
14fed3f
037f3de
5dfcaf9
432afbf
863a75c
45d4231
64602e1
ab9b05c
9ca0844
ccd15ef
4ca7bdd
5dad8d5
00cb4ce
8c53322
f884bfd
b411bda
14d60e6
48b3019
b31f20d
ec3cd62
1483a61
9de67b2
d0b256f
b8ecbfc
ee6e2ac
a3e0f2f
e3e505d
24eb8f5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,16 +21,9 @@ repositories { | |
| includeGroup "com.facebook.react" | ||
| } | ||
| } | ||
| maven { | ||
| url "https://a8c-libs.s3.amazonaws.com/android/hermes-mirror" | ||
| content { | ||
| includeGroup "org.wordpress-mobile" | ||
| } | ||
| } | ||
| google() | ||
| mavenCentral() | ||
| maven { url "https://www.jitpack.io" } | ||
| maven { url "https://a8c-libs.s3.amazonaws.com/android/hermes-mirror" } | ||
| } | ||
|
|
||
| android { | ||
|
|
@@ -74,9 +67,28 @@ dependencies { | |
| strictly wordPressAztecVersion | ||
| } | ||
| } | ||
|
|
||
| // Forcing version due to https://github.com/facebook/SoLoader/issues/94 | ||
| // To be removed with React Native 0.70+ | ||
| implementation("com.facebook.soloader:soloader") { | ||
| version { | ||
| strictly '0.10.4' | ||
| } | ||
| } | ||
|
|
||
| implementation 'com.facebook.fresco:fresco:2.5.0' | ||
| implementation 'com.facebook.fresco:imagepipeline-okhttp3:2.5.0' | ||
| implementation 'com.facebook.fbjni:fbjni:0.2.2' | ||
| implementation 'com.facebook.react:hermes-engine:0.69.4:release@aar' | ||
| implementation 'com.facebook.react:react-native:0.69.4:release@aar' | ||
|
Comment on lines
+79
to
+83
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Are these the libraries not included in the React Native and Hermes binaries? I'm wondering if we'd need to define them here or if they could be part of the libraries required by Gutenberg Mobile, could we have them as dependencies in the I noticed that we are also setting the React Native version, is this required? Would be a way to let the Gutenberg Mobile library to define this?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since we encountered issues with using the I'm working on a draft PR as a follow-up to improve these, although to be able to force the release artifacts for all builds like (Jalapeno Debug) which are the builds PRs generate, we will have to keep a few implementations. 😅 |
||
|
|
||
| // This dependency will be substituted if the `local-builds.gradle` file contains | ||
| // `localGutenbergMobilePath`. Details for this can be found in the `settings.gradle` file. | ||
| implementation "$rootProject.gradle.ext.gutenbergMobileBinaryPath:$rootProject.ext.gutenbergMobileVersion" | ||
| implementation ("$rootProject.gradle.ext.gutenbergMobileBinaryPath:$rootProject.ext.gutenbergMobileVersion") { | ||
| exclude module: 'hermes-engine' | ||
| exclude module: 'react-native' | ||
| } | ||
|
|
||
| // Required Aztec dependencies (they should be included but Jitpack seems to be stripping these out) | ||
| implementation "org.jsoup:jsoup:$jsoupVersion" | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.