Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Configuration Cache] Disable Configuration Cache on CI (V2) #21690

Closed
wants to merge 11 commits into from

Conversation

ParaskP7
Copy link
Contributor

@ParaskP7 ParaskP7 commented Feb 18, 2025

Related (Gradle 8.8 & AGP 8.5.1): #21659

Description:

This change is primarily about disabling configuration cache (CC) on CI. But, before doing so, we should verify that disabling CC on CI is actually going improve build times, and if not.


To Test:

Testing on Gradle 8.12.1 and AGP 8.8.1 environment:

Job BT (With) BT (Without) BT (Diff) DR - Conf (With) DR - Exec (Without) DR (Diff) TE - Time [Factor] (With) TE - Time [Factor] (Without) TE (Diff)
Jetpack App 13m 31s 15m 21s +1m 50s (❌) 2s 3s +1s (❌) 10m 17s [2.04x] 11m 41s [1.75s] +1m 24s (❌)
WordPress App 15m 21s 17m 35s +2m 14s (❌) 2s 3s +1s (❌) 11m 34s [2.02x] 12m 55s [1.76x] +1m 21s (❌)
Jetpack Lint 5m 36s 5m 54s +18s (❌) 2s 4s +2s (❌) 2m 9s [6.48x] 2m 14s [5.4x] +5s (❌)
WordPress Lint 5m 49s 5m 8s -41s (✅) 3s 2s -1s (✅) 2m 8s [5.94x] 2m 1s [5.48x] -7s (✅)
WordPress Unit Tests 5m 43s 4m 57s -46s (✅) 2s 3s +1s (❌) 2m 9s [5.13x] 2m 4s [4.19x] -5s (✅)
Processors Unit Tests 2m 56s 3m 8s +12s (❌) 0s 0s 0s (☑️) 7s [1.54x] 9s [1.46x] +2s (❌)
Image Editor Unit Tests 3m 2s 3m 41s +39s (❌) 0s 1s TODO () 12s [5.18x] 16s [4.13x] +4s (❌)
FluxC Unit Tests 3m 32s 4m 24s +52s (❌) 0s 1s +1s (❌) 33s [2.71s] 41s [2.08x] +8s (❌)
Login Unit Tests 3m 45s 3m 52s +7s (❌) 1s 1s 0s (☑️) 33s [3.1x] 35s [2.72x] +2s (❌)

Note

  • Without: Without Configuration Cache
  • With: With Configuration Cache
  • BT: Build Time
  • DR: Dependency Resolution -
    • Conf: During configuration
    • Exec: During execution
  • TE: Task Execution
    • Time [Factor]: Time spent executing tasks [Serial execution factor]
Assemble (Jetpack) BT (With CC ) BT (Without CC) BT (Diff)
Without BC (Without DC) 18m 29s 16m 18s -2m 11s (✅)
Without BC (With DC) 14m 6s 16m 24s +2m 18s (❌)
With BC (Without DC) 15m 55s 15m 19s -36s (✅)
With BC (With DC)1 5m 14s 5m 43s +29s (❌)

Note

  • CC: Configuration Cache
  • BC: Build Cache
  • DC: Dependency Cache

Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • See To Test section above.
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones): N/A

Footnotes

  1. You could also check this x10 build for some aggregate numbers. | (JP) BT (With CC ): 5m 12s | (JP) BT (Without CC ): 5m 44s | (WP) BT (With CC ): 13m 43s | (WP) BT (Without CC ): 13m 39s |

@ParaskP7 ParaskP7 added Core Tooling Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging labels Feb 18, 2025
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 18, 2025

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21690-43f1e47
Commit43f1e47
Direct Downloadwordpress-prototype-build-pr21690-43f1e47.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 18, 2025

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21690-43f1e47
Commit43f1e47
Direct Downloadjetpack-prototype-build-pr21690-43f1e47.apk
Note: Google Login is not supported on these builds.

@ParaskP7 ParaskP7 closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging Tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants