Remove check for modified main strings.xml outside release branch
#22382
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Danger check was out of place as `WordPress/src/main/res/values/strings.xml` is the source of truth for localizations. Unlike in Apple projects, where we use `genstrings` to find localized strings in the codebase to assemble the `strings` file, in Android, as far as I understand, `<app>/src/main/res/valudes/strings.xml` is the source of truth. I believe this check ended up in `Dangerfile` accidentally. It was introduced in #20132. The update was done across our suite of apps, see for example woocommerce/woocommerce-android#10692 and woocommerce/woocommerce-ios#11926. Given I couldn't find a comment explicitly about adopting this check, I guess neither @iangmaia nor myself notice the same pattern as iOS was adopted in the Android repo. To reinforce the idea that this check is out of place, notice that WooCommerce Android does not implement the check. _Of course, it could be that WooCommerce is wrong, but lacking code to update `strings.xml` as part of the code freeze process, that explanation is not satisfying._
|
Contributor
|
| App Name | Jetpack | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22382-451040e | |
| Commit | 451040e | |
| Direct Download | jetpack-prototype-build-pr22382-451040e.apk |
Contributor
|
| App Name | WordPress | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22382-451040e | |
| Commit | 451040e | |
| Direct Download | wordpress-prototype-build-pr22382-451040e.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Danger check was out of place as
WordPress/src/main/res/values/strings.xmlis the source of truth for localizations.Unlike in Apple projects, where we use
genstringsto find localized strings in the codebase to assemble thestringsfile, in Android, as far as I understand,<app>/src/main/res/valudes/strings.xmlis the source of truth.I believe this check ended up in
Dangerfileaccidentally. It was introduced in#20132. The update was done across our suite of apps, see for example woocommerce/woocommerce-android#10692 and woocommerce/woocommerce-ios#11926. Given I couldn't find a comment explicitly about adopting this check, I guess neither @iangmaia nor myself notice the same pattern as iOS was adopted in the Android repo.
To reinforce the idea that this check is out of place, notice that WooCommerce Android does not implement the check. Of course, it could be that WooCommerce is wrong, but lacking code to update
strings.xmlas part of the code freeze process, that explanation is not satisfying.Testing instructions
See this test PR: #22383